ash/shelf/shelf_view.cc - Issue 1812013003: Pass shelf instances, not root windows, for ash context menus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/shelf_view.cc

Issue 1812013003: Pass shelf instances, not root windows, for ash context menus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call OnShelfAlignmentChanged after LayoutShelf. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shelf/shelf_view.cc

diff --git a/ash/shelf/shelf_view.cc b/ash/shelf/shelf_view.cc

index 1217e74cf3066d5a043243e04090b73aac755066..67af1100a2da13be3104c119e1e543ea46e4fb58 100644

--- a/ash/shelf/shelf_view.cc

+++ b/ash/shelf/shelf_view.cc

@@ -1798,8 +1798,7 @@ void ShelfView::ShowContextMenuForView(views::View* source,

}

context_menu_model_.reset(Shell::GetInstance()->delegate()->CreateContextMenu(

- source->GetWidget()->GetNativeView()->GetRootWindow(),

- &model_->items()[view_index]));

+ shelf_, &model_->items()[view_index]));

if (!context_menu_model_)

return;

« no previous file with comments | « ash/shelf/shelf_layout_manager.cc ('k') | ash/shell.h » ('j') | no next file with comments »