ash/mus/shell_delegate_mus.cc - Issue 1812013003: Pass shelf instances, not root windows, for ash context menus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/mus/shell_delegate_mus.cc

Issue 1812013003: Pass shelf instances, not root windows, for ash context menus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call OnShelfAlignmentChanged after LayoutShelf. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/mus/shell_delegate_mus.cc

diff --git a/ash/mus/shell_delegate_mus.cc b/ash/mus/shell_delegate_mus.cc

index 4aa6e133a23516b87ebe6076e0d2f14318145e4a..7f627e10078486acc7b5b6144b3fb5ddc60cc243 100644

--- a/ash/mus/shell_delegate_mus.cc

+++ b/ash/mus/shell_delegate_mus.cc

@@ -197,7 +197,7 @@ MediaDelegate* ShellDelegateMus::CreateMediaDelegate() {

return new MediaDelegateStub;

}

-ui::MenuModel* ShellDelegateMus::CreateContextMenu(aura::Window* root_window,

+ui::MenuModel* ShellDelegateMus::CreateContextMenu(ash::Shelf* shelf,

const ShelfItem* item) {

NOTIMPLEMENTED();

return nullptr;

« no previous file with comments | « ash/mus/shell_delegate_mus.h ('k') | ash/root_window_controller.cc » ('j') | no next file with comments »