Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1808933002: Remove framebufferRenderbuffer and framebufferTexture* from WGC3D. (Closed)

Created:
4 years, 9 months ago by danakj
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, blundell+watchlist_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dcheng, dglazkov+blink, dshwang, droger+watchlist_chromium.org, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, jochen+watch_chromium.org, Justin Novosad, kinuko+watch, mlamouri+watch-test-runner_chromium.org, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, piman, rwlbuis, Stephen Chennney, sdefresne+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@wgc3d-unused
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove framebufferRenderbuffer and framebufferTexture* from WGC3D. This removes the method from the WebGraphicsContext3D API, and makes callers go directly to the GLES2Interface instead. The DepthStencilTrackingGLES2Interface is introduced for the DepthStencilTrackingContext to use in DrawingBufferTest, and code will migrate to it as methods are replaced in WebGraphicsContext3D. R=kbr@chromium.org BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/823b7378c01290d0a29e2052554d497e87530490 Cr-Commit-Position: refs/heads/master@{#381799}

Patch Set 1 : framebufferRenderbuffer #

Patch Set 2 : framebufferRenderbuffer: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -137 lines) Patch
M components/test_runner/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/test_plugin.h View 2 chunks +7 lines, -0 lines 0 comments Download
M components/test_runner/test_plugin.cc View 6 chunks +11 lines, -37 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.h View 1 2 chunks +0 lines, -14 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp View 3 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h View 2 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp View 7 chunks +17 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp View 3 chunks +37 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/test/MockWebGraphicsContext3D.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebGraphicsContext3D.h View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 32 (16 generated)
danakj
4 years, 9 months ago (2016-03-16 22:41:56 UTC) #2
danakj
+pfeldman for components/test_runner +chrishtr for public/
4 years, 9 months ago (2016-03-16 22:42:24 UTC) #4
chrishtr
lgtm
4 years, 9 months ago (2016-03-16 22:44:37 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808933002/1
4 years, 9 months ago (2016-03-16 23:30:42 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/157826)
4 years, 9 months ago (2016-03-16 23:42:40 UTC) #9
danakj
+zmo in case you're able to review the webgl pieces
4 years, 9 months ago (2016-03-16 23:53:48 UTC) #11
pfeldman
lgtm
4 years, 9 months ago (2016-03-17 00:23:55 UTC) #12
danakj
kbr/zmo please hit commit if you like it.
4 years, 9 months ago (2016-03-17 00:52:39 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808933002/1
4 years, 9 months ago (2016-03-17 01:07:44 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808933002/20001
4 years, 9 months ago (2016-03-17 19:05:14 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 21:07:01 UTC) #21
danakj
+sievers
4 years, 9 months ago (2016-03-17 21:13:54 UTC) #23
no sievers
lgtm
4 years, 9 months ago (2016-03-17 21:19:44 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808933002/20001
4 years, 9 months ago (2016-03-17 21:22:26 UTC) #28
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 21:28:39 UTC) #30
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 21:29:51 UTC) #32
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/823b7378c01290d0a29e2052554d497e87530490
Cr-Commit-Position: refs/heads/master@{#381799}

Powered by Google App Engine
This is Rietveld 408576698