Add an infrastructure to query history.google.com about other forms of browsing history.

Add an infrastructure to query history.google.com about other forms of browsing history.

The Clear Browsing Data dialog UI will provide a notice informing the
user that history.google.com stores other forms of browsing history
(such as the search history).

We will only show the notice to those users for whom it is valid. This
will be determined by Sync status, and by a JSON response from
history.google.com [not yet implemented].

See https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/
for the background.

To communicate between backends (ProfileSyncService, HistoryService) and
frontends on all platforms, we need to put this logic to a component
(especially because of iOS). We create a new component "browsing_data_ui".

BUG=595332
Committed: https://crrev.com/b6d0d3c36ca322e5f2cb4513198f9d91b5ee53a9
Cr-Commit-Position: refs/heads/master@{#381804}

[msramek, 2016-03-16 15:04:13]

Description was changed from

==========
Add an infrastructure to query history.google.com about other forms of browsing
history.

The Clear Browsing Data dialog UI will provide a notice informing the
user that history.google.com stores other forms of browsing history
(such as the search history).

We will only show the notice to those users for whom it is valid. This
will be determined by Sync status, and by a JSON response from
history.google.com [not yet implemented].

To communicate between backends (ProfileSyncService, HistoryService) and
frontends on all platforms, we need to put this logic to a component
(especially because of iOS). Considering that the purpose is for it to be
used for the CBD dialog, the browsing_data/ component seems suitable.

Note that the browser_sync_browser requires the sync/protocol/sync.pb.h
to be generated, otherwise the inclusion doesn't work. This can be solved
by adding sync/sync.gyp:sync to the dependencies of browsing_data, or,
more generally, by exposing it (by export_dependent_settings) through
the dependency chain sync_driver->browser_sync_browser->browsing_data.
This CL implements the second option.

BUG=
==========

to

==========
Add an infrastructure to query history.google.com about other forms of browsing
history.

The Clear Browsing Data dialog UI will provide a notice informing the
user that history.google.com stores other forms of browsing history
(such as the search history).

We will only show the notice to those users for whom it is valid. This
will be determined by Sync status, and by a JSON response from
history.google.com [not yet implemented].

See
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/
for the background.

To communicate between backends (ProfileSyncService, HistoryService) and
frontends on all platforms, we need to put this logic to a component
(especially because of iOS). Considering that the purpose is for it to be
used for the CBD dialog, the browsing_data/ component seems suitable.

Note that the browser_sync_browser requires the sync/protocol/sync.pb.h
to be generated, otherwise the inclusion doesn't work. This can be solved
by adding sync/sync.gyp:sync to the dependencies of browsing_data, or,
more generally, by exposing it (by export_dependent_settings) through
the dependency chain sync_driver->browser_sync_browser->browsing_data.
This CL implements the second option.

BUG=595332
==========

[msramek, 2016-03-16 15:10:48]

Patchset #1 (id:1) has been deleted

[msramek, 2016-03-16 15:16:07]

msramek@chromium.org changed reviewers:
+ blundell@chromium.org, mkwst@chromium.org, msarda@chromium.org,
sdefresne@chromium.org

[msramek, 2016-03-16 15:16:08]

Hi guys,

please have a look! As explained in the CL description, this CL doesn't do
anything in itself, it's just a glue that will allow us to parallelize the work
on history backend and different frontends. Please see the linked design doc for
more background.

mkwst@: browsing_data/
sdefresne@: history/
blundell@: component dependencies (please see the last paragraph of the CL
description)
msarda@: sanity check for iOS

Thank you!
Martin

[blundell, 2016-03-16 15:22:40]

What is the chain of includes that is causing profile_sync_service.h to
transitively include sync.pb.h?

[msarda, 2016-03-16 15:23:44]

lgtm

[msramek, 2016-03-16 15:25:39]

Description was changed from

==========
Add an infrastructure to query history.google.com about other forms of browsing
history.

The Clear Browsing Data dialog UI will provide a notice informing the
user that history.google.com stores other forms of browsing history
(such as the search history).

We will only show the notice to those users for whom it is valid. This
will be determined by Sync status, and by a JSON response from
history.google.com [not yet implemented].

See
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/
for the background.

To communicate between backends (ProfileSyncService, HistoryService) and
frontends on all platforms, we need to put this logic to a component
(especially because of iOS). Considering that the purpose is for it to be
used for the CBD dialog, the browsing_data/ component seems suitable.

Note that the browser_sync_browser requires the sync/protocol/sync.pb.h
to be generated, otherwise the inclusion doesn't work. This can be solved
by adding sync/sync.gyp:sync to the dependencies of browsing_data, or,
more generally, by exposing it (by export_dependent_settings) through
the dependency chain sync_driver->browser_sync_browser->browsing_data.
This CL implements the second option.

BUG=595332
==========

to

==========
Add an infrastructure to query history.google.com about other forms of browsing
history.

The Clear Browsing Data dialog UI will provide a notice informing the
user that history.google.com stores other forms of browsing history
(such as the search history).

We will only show the notice to those users for whom it is valid. This
will be determined by Sync status, and by a JSON response from
history.google.com [not yet implemented].

See
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/
for the background.

To communicate between backends (ProfileSyncService, HistoryService) and
frontends on all platforms, we need to put this logic to a component
(especially because of iOS). Considering that the purpose is for it to be
used for the CBD dialog, the browsing_data/ component seems suitable.

Note that ProfileSyncService requires the file sync/protocol/sync.pb.h
to be generated. Including browser_sync_browser to browsing_data did
not cause the file to be generated when compiling browsing_data. This
can be solved by adding sync/sync.gyp:sync to the dependencies of
browsing_data, or, more generally, by exposing it (export_dependent_settings)
through the dependency chain sync_driver->browser_sync_browser->browsing_data.
This CL implements the second option.

BUG=595332
==========

[msramek, 2016-03-16 15:27:48]

On 2016/03/16 15:22:40, blundell wrote:
> What is the chain of includes that is causing profile_sync_service.h to
> transitively include sync.pb.h?

browser_sync_browser->sync_driver->sync/sync.gyp:sync->sync/sync.gyp:sync_proto.

(I also rephrased the CL description a bit, as it was hastily written and
somewhat illegible, sorry).

[blundell, 2016-03-16 15:29:45]

On 2016/03/16 15:27:48, msramek wrote:
> On 2016/03/16 15:22:40, blundell wrote:
> > What is the chain of includes that is causing profile_sync_service.h to
> > transitively include sync.pb.h?
> 
>
browser_sync_browser->sync_driver->sync/sync.gyp:sync->sync/sync.gyp:sync_proto.
> 
> (I also rephrased the CL description a bit, as it was hastily written and
> somewhat illegible, sorry).

Sorry, I meant the chain at the header level.

[msramek, 2016-03-16 15:34:41]

On 2016/03/16 15:29:45, blundell wrote:
> On 2016/03/16 15:27:48, msramek wrote:
> > On 2016/03/16 15:22:40, blundell wrote:
> > > What is the chain of includes that is causing profile_sync_service.h to
> > > transitively include sync.pb.h?
> > 
> >
>
browser_sync_browser->sync_driver->sync/sync.gyp:sync->sync/sync.gyp:sync_proto.
> > 
> > (I also rephrased the CL description a bit, as it was hastily written and
> > somewhat illegible, sorry).
> 
> Sorry, I meant the chain at the header level.

Ah, right. Here it is:

../../components/browsing_data/history_notice_utils.cc:7:
../../components/browser_sync/browser/profile_sync_service.h:32:
../../components/sync_driver/device_info_sync_service.h:19:
../../components/sync_driver/device_info_tracker.h:12:
../../components/sync_driver/device_info.h:12:10:
fatal error: 'sync/protocol/sync.pb.h' file not found

[blundell, 2016-03-16 15:48:06]

dependencies LGTM

note that I just lgtm'd the whole CL in effect; please don't land until you have
everyone else's LGTM as well :).

[blundell, 2016-03-16 15:49:08]

https://codereview.chromium.org/1806873002/diff/20001/components/browsing_dat...
File components/browsing_data/BUILD.gn (right):

https://codereview.chromium.org/1806873002/diff/20001/components/browsing_dat...
components/browsing_data/BUILD.gn:18: "//components/browser_sync/browser",
actually, a question: Why no corresponding dependency chain changes for GN
(i.e., making some deps into public_deps)? Are things already set up correctly
in the GN dependency chain here?

[msramek, 2016-03-16 16:01:08]

Thanks, Colin!

https://codereview.chromium.org/1806873002/diff/20001/components/browsing_dat...
File components/browsing_data/BUILD.gn (right):

https://codereview.chromium.org/1806873002/diff/20001/components/browsing_dat...
components/browsing_data/BUILD.gn:18: "//components/browser_sync/browser",
On 2016/03/16 15:49:08, blundell wrote:
> actually, a question: Why no corresponding dependency chain changes for GN
> (i.e., making some deps into public_deps)? Are things already set up correctly
> in the GN dependency chain here?

Yes, I tried compiling with GN, and there sync.pb.h was correctly generated.

[blundell, 2016-03-16 16:04:23]

On 2016/03/16 16:01:08, msramek wrote:
> Thanks, Colin!
> 
>
https://codereview.chromium.org/1806873002/diff/20001/components/browsing_dat...
> File components/browsing_data/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1806873002/diff/20001/components/browsing_dat...
> components/browsing_data/BUILD.gn:18: "//components/browser_sync/browser",
> On 2016/03/16 15:49:08, blundell wrote:
> > actually, a question: Why no corresponding dependency chain changes for GN
> > (i.e., making some deps into public_deps)? Are things already set up
correctly
> > in the GN dependency chain here?
> 
> Yes, I tried compiling with GN, and there sync.pb.h was correctly generated.

Actually, I just looked, and it looks like there are similar problems there:
//components/browser_sync/browser should have a public_dep on
//components/sync_driver
and likewise for //components/sync_driver to //sync

Note that a build succeeding doesn't give definitive info since missing
dependencies induce flaky build failures rather than deterministic build
failures.

[msramek, 2016-03-16 18:52:04]

On 2016/03/16 16:04:23, blundell wrote:
> On 2016/03/16 16:01:08, msramek wrote:
> > Thanks, Colin!
> > 
> >
>
https://codereview.chromium.org/1806873002/diff/20001/components/browsing_dat...
> > File components/browsing_data/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/1806873002/diff/20001/components/browsing_dat...
> > components/browsing_data/BUILD.gn:18: "//components/browser_sync/browser",
> > On 2016/03/16 15:49:08, blundell wrote:
> > > actually, a question: Why no corresponding dependency chain changes for GN
> > > (i.e., making some deps into public_deps)? Are things already set up
> correctly
> > > in the GN dependency chain here?
> > 
> > Yes, I tried compiling with GN, and there sync.pb.h was correctly generated.
> 
> Actually, I just looked, and it looks like there are similar problems there:
> //components/browser_sync/browser should have a public_dep on
> //components/sync_driver
> and likewise for //components/sync_driver to //sync
> 
> Note that a build succeeding doesn't give definitive info since missing
> dependencies induce flaky build failures rather than deterministic build
> failures.

Good to know! Done.

[sdefresne, 2016-03-17 09:49:39]

Can you please answer question about //content dependency?

https://codereview.chromium.org/1806873002/diff/40001/components/browsing_dat...
File components/browsing_data/history_notice_utils.cc (right):

https://codereview.chromium.org/1806873002/diff/40001/components/browsing_dat...
components/browsing_data/history_notice_utils.cc:15: return (sync_service &&
nit: return is not a function, so you can remove the superfluous parentheses

return sync_service && ...

https://codereview.chromium.org/1806873002/diff/40001/components/browsing_dat...
File components/browsing_data/history_notice_utils.h (right):

https://codereview.chromium.org/1806873002/diff/40001/components/browsing_dat...
components/browsing_data/history_notice_utils.h:18: bool
ShouldShowNoticeAboutOtherFormsOfBrowsingHistory(
You CL description says "we need to put this logic to a component (especially
because of iOS)" however iOS cannot use components that depends on //content. So
you'll either have to remove the dependency on //content from
//components/browsing_data or move the code into another component.

See components/browsing_data.gypi, components/browsing_data/BUILD.gn and
components/browsing_data/DEPS for the dependency on //content.

What is your plan here?

[msramek, 2016-03-17 13:00:02]

Patchset #3 (id:60001) has been deleted

[msramek, 2016-03-17 13:04:34]

Moved to a new component. PTAL!

https://codereview.chromium.org/1806873002/diff/40001/components/browsing_dat...
File components/browsing_data/history_notice_utils.cc (right):

https://codereview.chromium.org/1806873002/diff/40001/components/browsing_dat...
components/browsing_data/history_notice_utils.cc:15: return (sync_service &&
On 2016/03/17 09:49:39, sdefresne wrote:
> nit: return is not a function, so you can remove the superfluous parentheses
> 
> return sync_service && ...

Done.

https://codereview.chromium.org/1806873002/diff/40001/components/browsing_dat...
File components/browsing_data/history_notice_utils.h (right):

https://codereview.chromium.org/1806873002/diff/40001/components/browsing_dat...
components/browsing_data/history_notice_utils.h:18: bool
ShouldShowNoticeAboutOtherFormsOfBrowsingHistory(
On 2016/03/17 09:49:39, sdefresne wrote:
> You CL description says "we need to put this logic to a component (especially
> because of iOS)" however iOS cannot use components that depends on //content.
So
> you'll either have to remove the dependency on //content from
> //components/browsing_data or move the code into another component.
> 
> See components/browsing_data.gypi, components/browsing_data/BUILD.gn and
> components/browsing_data/DEPS for the dependency on //content.
> 
> What is your plan here?

OK, I wasn't aware of that. Now I can see that browsing_data is also explicitly
listed in the non-iOS sources of components.gyp/BUILD.gn.

After an offline chat with msarda@, I decided to move this to a separate
component. It feels to be a bit of an overkill for one method, but since this CL
introduces the glue that both of us need for the UI work, and it also fixes the
dependency chain in Sync, let me just roll with it. In the end, it's not
unlikely that we will add more stuff here, or repurpose the component for more
CBD dialog-related things.

[sdefresne, 2016-03-17 13:11:20]

Can you please split your CL in two?

One part to fix the dependencies, another to introduce your changes.

https://codereview.chromium.org/1806873002/diff/80001/components/browser_sync...
File components/browser_sync.gypi (right):

https://codereview.chromium.org/1806873002/diff/80001/components/browser_sync...
components/browser_sync.gypi:41: 'export_dependent_settings': [
It looks like this change is orthogonal, can you extract to another CL?

https://codereview.chromium.org/1806873002/diff/80001/components/browser_sync...
File components/browser_sync/browser/BUILD.gn (right):

https://codereview.chromium.org/1806873002/diff/80001/components/browser_sync...
components/browser_sync/browser/BUILD.gn:17: public_deps = [
ditto

https://codereview.chromium.org/1806873002/diff/80001/components/history_noti...
File components/history_notice_utils.gypi (left):

https://codereview.chromium.org/1806873002/diff/80001/components/history_noti...
components/history_notice_utils.gypi:1: # Copyright 2015 The Chromium Authors.
All rights reserved.
I don't like "history_notice_utils" name. Why not "history_ui" or
"browsing_data_ui"?

https://codereview.chromium.org/1806873002/diff/80001/components/history_noti...
components/history_notice_utils.gypi:8: # GN version:
//components/profile_metrics
nit: can you have

# GN version: //components/history_notice_utils

https://codereview.chromium.org/1806873002/diff/80001/components/history_noti...
File components/history_notice_utils.gypi (right):

https://codereview.chromium.org/1806873002/diff/80001/components/history_noti...
components/history_notice_utils.gypi:19:
'history_notice_utils/history_notice_utils.cc',
nit: avoid mixing tab and space (prefer space), and use consistent indentation

https://codereview.chromium.org/1806873002/diff/80001/components/history_noti...
File components/history_notice_utils/history_notice_utils.h (right):

https://codereview.chromium.org/1806873002/diff/80001/components/history_noti...
components/history_notice_utils/history_notice_utils.h:7: 
nit: the order in other files seems to be forward-declaration (sorted) in global
namespace, then forward-declaration (sorted) in other namespace (sorted).

https://codereview.chromium.org/1806873002/diff/80001/components/sync_driver....
File components/sync_driver.gypi (right):

https://codereview.chromium.org/1806873002/diff/80001/components/sync_driver....
components/sync_driver.gypi:25: '../sync/sync.gyp:sync',
ditto

https://codereview.chromium.org/1806873002/diff/80001/components/sync_driver/...
File components/sync_driver/BUILD.gn (right):

https://codereview.chromium.org/1806873002/diff/80001/components/sync_driver/...
components/sync_driver/BUILD.gn:129: "//sync",
ditto

[msramek, 2016-03-17 13:54:01]

Patchset #5 (id:120001) has been deleted

[msramek, 2016-03-17 13:56:50]

Description was changed from

==========
Add an infrastructure to query history.google.com about other forms of browsing
history.

The Clear Browsing Data dialog UI will provide a notice informing the
user that history.google.com stores other forms of browsing history
(such as the search history).

We will only show the notice to those users for whom it is valid. This
will be determined by Sync status, and by a JSON response from
history.google.com [not yet implemented].

See
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/
for the background.

To communicate between backends (ProfileSyncService, HistoryService) and
frontends on all platforms, we need to put this logic to a component
(especially because of iOS). Considering that the purpose is for it to be
used for the CBD dialog, the browsing_data/ component seems suitable.

Note that ProfileSyncService requires the file sync/protocol/sync.pb.h
to be generated. Including browser_sync_browser to browsing_data did
not cause the file to be generated when compiling browsing_data. This
can be solved by adding sync/sync.gyp:sync to the dependencies of
browsing_data, or, more generally, by exposing it (export_dependent_settings)
through the dependency chain sync_driver->browser_sync_browser->browsing_data.
This CL implements the second option.

BUG=595332
==========

to

==========
Add an infrastructure to query history.google.com about other forms of browsing
history.

The Clear Browsing Data dialog UI will provide a notice informing the
user that history.google.com stores other forms of browsing history
(such as the search history).

We will only show the notice to those users for whom it is valid. This
will be determined by Sync status, and by a JSON response from
history.google.com [not yet implemented].

See
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/
for the background.

To communicate between backends (ProfileSyncService, HistoryService) and
frontends on all platforms, we need to put this logic to a component
(especially because of iOS). We create a new component "browsing_data_ui".

BUG=595332
==========

[msramek, 2016-03-17 13:58:20]

https://codereview.chromium.org/1806873002/diff/80001/components/browser_sync...
File components/browser_sync.gypi (right):

https://codereview.chromium.org/1806873002/diff/80001/components/browser_sync...
components/browser_sync.gypi:41: 'export_dependent_settings': [
On 2016/03/17 13:11:20, sdefresne wrote:
> It looks like this change is orthogonal, can you extract to another CL?

It's not really orthogonal, this CL doesn't compile without that change.

I uploaded https://codereview.chromium.org/1808223002/ and rebased on top of it.

https://codereview.chromium.org/1806873002/diff/80001/components/history_noti...
File components/history_notice_utils.gypi (left):

https://codereview.chromium.org/1806873002/diff/80001/components/history_noti...
components/history_notice_utils.gypi:1: # Copyright 2015 The Chromium Authors.
All rights reserved.
On 2016/03/17 13:11:20, sdefresne wrote:
> I don't like "history_notice_utils" name. Why not "history_ui" or
> "browsing_data_ui"?

browsing_data_ui SGTM.

https://codereview.chromium.org/1806873002/diff/80001/components/history_noti...
File components/history_notice_utils.gypi (right):

https://codereview.chromium.org/1806873002/diff/80001/components/history_noti...
components/history_notice_utils.gypi:19:
'history_notice_utils/history_notice_utils.cc',
On 2016/03/17 13:11:20, sdefresne wrote:
> nit: avoid mixing tab and space (prefer space), and use consistent indentation

Done. Yeah, this is a copy-paste error. I actually made the same one in GN, but
there it was caught by a presubmit check.

https://codereview.chromium.org/1806873002/diff/80001/components/history_noti...
File components/history_notice_utils/history_notice_utils.h (right):

https://codereview.chromium.org/1806873002/diff/80001/components/history_noti...
components/history_notice_utils/history_notice_utils.h:7: 
On 2016/03/17 13:11:20, sdefresne wrote:
> nit: the order in other files seems to be forward-declaration (sorted) in
global
> namespace, then forward-declaration (sorted) in other namespace (sorted).

Done.

[sdefresne, 2016-03-17 17:55:53]

lgtm

https://codereview.chromium.org/1806873002/diff/140001/components/browsing_da...
File components/browsing_data_ui/BUILD.gn (right):

https://codereview.chromium.org/1806873002/diff/140001/components/browsing_da...
components/browsing_data_ui/BUILD.gn:6: output_name = "browsing_data_ui"
You don't need this as it default to the name of the target.

[msramek, 2016-03-17 19:54:04]

This is no touching browsing_data/ anymore, so I'm not waiting for Mike's LGTM.

Merci, Parisiens! :)

https://codereview.chromium.org/1806873002/diff/140001/components/browsing_da...
File components/browsing_data_ui/BUILD.gn (right):

https://codereview.chromium.org/1806873002/diff/140001/components/browsing_da...
components/browsing_data_ui/BUILD.gn:6: output_name = "browsing_data_ui"
On 2016/03/17 17:55:53, sdefresne wrote:
> You don't need this as it default to the name of the target.

Done.

[msramek, 2016-03-17 19:54:12]

The CQ bit was checked by msramek@chromium.org

[msramek, 2016-03-17 19:54:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
blundell@chromium.org, msarda@chromium.org, sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/1806873002/#ps160001
(title: "Removed output_name")

[commit-bot: I haz the power, 2016-03-17 19:54:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1806873002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1806873002/160001

[commit-bot: I haz the power, 2016-03-17 21:50:45]

Description was changed from

==========
Add an infrastructure to query history.google.com about other forms of browsing
history.

The Clear Browsing Data dialog UI will provide a notice informing the
user that history.google.com stores other forms of browsing history
(such as the search history).

We will only show the notice to those users for whom it is valid. This
will be determined by Sync status, and by a JSON response from
history.google.com [not yet implemented].

See
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/
for the background.

To communicate between backends (ProfileSyncService, HistoryService) and
frontends on all platforms, we need to put this logic to a component
(especially because of iOS). We create a new component "browsing_data_ui".

BUG=595332
==========

to

==========
Add an infrastructure to query history.google.com about other forms of browsing
history.

The Clear Browsing Data dialog UI will provide a notice informing the
user that history.google.com stores other forms of browsing history
(such as the search history).

We will only show the notice to those users for whom it is valid. This
will be determined by Sync status, and by a JSON response from
history.google.com [not yet implemented].

See
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/
for the background.

To communicate between backends (ProfileSyncService, HistoryService) and
frontends on all platforms, we need to put this logic to a component
(especially because of iOS). We create a new component "browsing_data_ui".

BUG=595332
==========

[commit-bot: I haz the power, 2016-03-17 21:50:47]

Committed patchset #6 (id:160001)

[commit-bot: I haz the power, 2016-03-17 21:52:17]

Description was changed from

==========
Add an infrastructure to query history.google.com about other forms of browsing
history.

The Clear Browsing Data dialog UI will provide a notice informing the
user that history.google.com stores other forms of browsing history
(such as the search history).

We will only show the notice to those users for whom it is valid. This
will be determined by Sync status, and by a JSON response from
history.google.com [not yet implemented].

See
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/
for the background.

To communicate between backends (ProfileSyncService, HistoryService) and
frontends on all platforms, we need to put this logic to a component
(especially because of iOS). We create a new component "browsing_data_ui".

BUG=595332
==========

to

==========
Add an infrastructure to query history.google.com about other forms of browsing
history.

The Clear Browsing Data dialog UI will provide a notice informing the
user that history.google.com stores other forms of browsing history
(such as the search history).

We will only show the notice to those users for whom it is valid. This
will be determined by Sync status, and by a JSON response from
history.google.com [not yet implemented].

See
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/
for the background.

To communicate between backends (ProfileSyncService, HistoryService) and
frontends on all platforms, we need to put this logic to a component
(especially because of iOS). We create a new component "browsing_data_ui".

BUG=595332

Committed: https://crrev.com/b6d0d3c36ca322e5f2cb4513198f9d91b5ee53a9
Cr-Commit-Position: refs/heads/master@{#381804}
==========

[commit-bot: I haz the power, 2016-03-17 21:52:18]

Patchset 6 (id:??) landed as
https://crrev.com/b6d0d3c36ca322e5f2cb4513198f9d91b5ee53a9
Cr-Commit-Position: refs/heads/master@{#381804}