components/browsing_data/BUILD.gn - Issue 1806873002: Add an infrastructure to query history.google.com about other forms of browsing history.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/browsing_data/BUILD.gn

Issue 1806873002: Add an infrastructure to query history.google.com about other forms of browsing history. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 static_library("browsing_data") {	5 static_library("browsing_data") {

6 output_name = "browsing_data"	6 output_name = "browsing_data"

7 sources = [	7 sources = [

	8 "history_notice_utils.cc",

	9 "history_notice_utils.h",

8 "storage_partition_http_cache_data_remover.cc",	10 "storage_partition_http_cache_data_remover.cc",

9 "storage_partition_http_cache_data_remover.h",	11 "storage_partition_http_cache_data_remover.h",

10 ]	12 ]

11	13

12 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]	14 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]

13	15

14 deps = [	16 deps = [

15 "//base",	17 "//base",

	18 "//components/browser_sync/browser",
	blundell 2016/03/16 15:49:08 actually, a question: Why no corresponding depende actually, a question: Why no corresponding dependency chain changes for GN (i.e., making some deps into public_deps)? Are things already set up correctly in the GN dependency chain here? msramek 2016/03/16 16:01:08 Yes, I tried compiling with GN, and there sync.pb. Show quoted text On 2016/03/16 15:49:08, blundell wrote: > actually, a question: Why no corresponding dependency chain changes for GN > (i.e., making some deps into public_deps)? Are things already set up correctly > in the GN dependency chain here? Yes, I tried compiling with GN, and there sync.pb.h was correctly generated.
	19 "//components/history/core/browser",

16 "//content/public/browser",	20 "//content/public/browser",

17 "//net",	21 "//net",

18 ]	22 ]

19 }	23 }

OLD	NEW

« no previous file with comments | « components/browsing_data.gypi ('k') | components/browsing_data/DEPS » ('j') | no next file with comments »