components/browsing_data/history_notice_utils.cc - Issue 1806873002: Add an infrastructure to query history.google.com about other forms of browsing history.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/browsing_data/history_notice_utils.cc

Issue 1806873002: Add an infrastructure to query history.google.com about other forms of browsing history. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the GN chain. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/browsing_data/history_notice_utils.h ('K') | « components/browsing_data/history_notice_utils.h ('k') | components/history/core/browser/web_history_service.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/browsing_data/history_notice_utils.h"

	6

	7 #include "components/browser_sync/browser/profile_sync_service.h"

	8 #include "components/history/core/browser/web_history_service.h"

	9

	10 namespace browsing_data {

	11

	12 bool ShouldShowNoticeAboutOtherFormsOfBrowsingHistory(

	13 const ProfileSyncService* sync_service,

	14 const history::WebHistoryService* history_service) {

	15 return (sync_service &&
	sdefresne 2016/03/17 09:49:39 nit: return is not a function, so you can remove t nit: return is not a function, so you can remove the superfluous parentheses return sync_service && ... msramek 2016/03/17 13:04:34 Done. Show quoted text On 2016/03/17 09:49:39, sdefresne wrote: > nit: return is not a function, so you can remove the superfluous parentheses > > return sync_service && ... Done.
	16 sync_service->IsUsingSecondaryPassphrase() &&

	17 history_service &&

	18 history_service->HasOtherFormsOfBrowsingHistory());

	19 }

	20

	21 } // namespace browsing_data

OLD	NEW