Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 1808223002: Fix the build dependency of ProfileSyncService on sync.pb.h (Closed)

Created:
4 years, 9 months ago by msramek
Modified:
4 years, 9 months ago
Reviewers:
sdefresne, blundell
CC:
chromium-reviews, maxbogue+watch_chromium.org, plaree+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the build dependency of ProfileSyncService on sync.pb.h ProfileSyncService requires the file sync/protocol/sync.pb.h to be generated. However, including browser_sync_browser (which contains ProfileSyncService) does not guarantee that. This CL exposes sync/sync.gyp:sync (containing sync.pb.h) as a public dependency in sync_driver, and sync_driver as a public dependency in browser_sync_browser, so that any target with the dependency on browser_sync_browser will also generate sync.pb.h. BUG=595332 Committed: https://crrev.com/37f7b75bf619d4f853cfb2b7e4e17d1b290d9a9f Cr-Commit-Position: refs/heads/master@{#381712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M components/browser_sync.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M components/browser_sync/browser/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M components/sync_driver.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
msramek
This is the dependency chain fix from https://codereview.chromium.org/1806873002/, extracted into a separate base CL. PTAL! ...
4 years, 9 months ago (2016-03-17 13:59:28 UTC) #2
blundell
lgtm
4 years, 9 months ago (2016-03-17 15:01:24 UTC) #3
sdefresne
lgtm
4 years, 9 months ago (2016-03-17 15:10:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808223002/1
4 years, 9 months ago (2016-03-17 15:11:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 15:16:05 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 15:18:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37f7b75bf619d4f853cfb2b7e4e17d1b290d9a9f
Cr-Commit-Position: refs/heads/master@{#381712}

Powered by Google App Engine
This is Rietveld 408576698