Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright 2015 The Chromium Authors. All rights reserved. | 1 # Copyright 2016 The Chromium Authors. All rights reserved. |
|
sdefresne
2016/03/17 13:11:20
I don't like "history_notice_utils" name. Why not
msramek
2016/03/17 13:58:20
browsing_data_ui SGTM.
| |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 { | 5 { |
| 6 'targets': [ | 6 'targets': [ |
| 7 { | 7 { |
| 8 # GN version: //components/profile_metrics | 8 'target_name': 'history_notice_utils', |
|
sdefresne
2016/03/17 13:11:20
nit: can you have
# GN version: //components/hist
| |
| 9 'target_name': 'profile_metrics', | |
| 10 'type': 'static_library', | 9 'type': 'static_library', |
| 10 'dependencies': [ | |
| 11 'browser_sync_browser', | |
| 12 'history_core_browser', | |
| 13 ], | |
| 11 'include_dirs': [ | 14 'include_dirs': [ |
| 12 '..', | 15 '..', |
| 13 ], | 16 ], |
| 14 'dependencies': [ | |
| 15 '../base/base.gyp:base', | |
| 16 ], | |
| 17 'sources': [ | 17 'sources': [ |
| 18 # Note: sources list duplicated in GN build. | 18 # Note: sources list duplicated in GN build. |
| 19 'profile_metrics/counts.cc', | 19 » 'history_notice_utils/history_notice_utils.cc', |
|
sdefresne
2016/03/17 13:11:20
nit: avoid mixing tab and space (prefer space), an
msramek
2016/03/17 13:58:20
Done. Yeah, this is a copy-paste error. I actually
| |
| 20 'profile_metrics/counts.h', | 20 'history_notice_utils/history_notice_utils.h', |
| 21 ], | 21 ], |
| 22 }, | 22 }, |
| 23 ], | 23 ], |
| 24 } | 24 } |
| OLD | NEW |