Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1805243002: Make test_runner::LayoutDumpFlags an internal detail of components/test_runner. (Closed)

Created:
4 years, 9 months ago by Łukasz Anforowicz
Modified:
4 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-mock-screen-orientation-dep
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make test_runner::LayoutDumpFlags an internal detail of components/test_runner. To simplify public API surface of components/test_runner we can hide LayoutDumpFlags behind WebTestRunner interface. For example - instead of returning the whole LayoutDumpFlags struct, we can only expose IsRecursiveLayoutDumpRequested method - this is consistent with how other similar methods are exposed via WebTestRunner (i.e. we already have ShouldDumpAsAudio and/or ShouldGeneratePixelResults). After doing this components/test_runner/layout_dump_flags.h and components/test_runner/layout_dump.h headers no longer needs to be included outside of components/test_runner. BUG=595089 Committed: https://crrev.com/ef264fc5601239984a67e3a39580b6a7855142b8 Cr-Commit-Position: refs/heads/master@{#381819}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M components/test_runner/test_runner.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/test_runner/test_runner.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M components/test_runner/web_test_runner.h View 2 chunks +10 lines, -6 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_render_frame_observer.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
Łukasz Anforowicz
jochen@, can you take a look please?
4 years, 9 months ago (2016-03-16 00:16:39 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-17 19:51:43 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805243002/1
4 years, 9 months ago (2016-03-17 20:59:07 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 22:04:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805243002/1
4 years, 9 months ago (2016-03-17 22:42:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 22:49:28 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 22:51:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef264fc5601239984a67e3a39580b6a7855142b8
Cr-Commit-Position: refs/heads/master@{#381819}

Powered by Google App Engine
This is Rietveld 408576698