Make MockScreenOrientationClient an internal detail of components/test_runner.

Make MockScreenOrientationClient an internal detail of components/test_runner.

Ownership of MockScreenOrientationClient can be moved to TestRunner
(which holds ownership of other things that can be influenced by
javascript bindings).

Furthermore, TestRunner doesn't need to take a detour via
WebTestDelegate (aka BlinkTestRunner) to interact with
MockScreenOrientationClient.  This means that we can remove three
screen-orientation-related methods from WebTestDelegate.  This in turn
means that components/test_runner/mock_screen_orientation_client.h
header no longer needs to be included outside of components/test_runner.

BUG=595089
Committed: https://crrev.com/6a113ae1eed99940208bef750221d2f9ff058c9b
Cr-Commit-Position: refs/heads/master@{#381814}

[Łukasz Anforowicz, 2016-03-16 00:16:00]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-03-16 00:16:01]

jochen@, can you take a look please?

https://codereview.chromium.org/1807733002/diff/20001/components/test_runner/...
File components/test_runner/test_runner.cc (right):

https://codereview.chromium.org/1807733002/diff/20001/components/test_runner/...
components/test_runner/test_runner.cc:1705:
mock_screen_orientation_client_->ResetData();
This just copies method body from the deleted
BlinkTestRunner::ResetScreenOrientation method.

https://codereview.chromium.org/1807733002/diff/20001/components/test_runner/...
components/test_runner/test_runner.cc:2519: DCHECK_EQ("landscape-secondary",
orientation_str);
Otherwise |orientation| might not be initialized at all.

https://codereview.chromium.org/1807733002/diff/20001/components/test_runner/...
components/test_runner/test_runner.cc:2526: main_frame, orientation);
This just copies method body from the deleted
BlinkTestRunner::SetScreenOrientation method (and adds a TODO).

https://codereview.chromium.org/1807733002/diff/20001/components/test_runner/...
components/test_runner/test_runner.cc:2530:
mock_screen_orientation_client_->SetDisabled(true);
This just copies method body from the deleted
BlinkTestRunner::DisableMockScreenOrientation method.

https://codereview.chromium.org/1807733002/diff/20001/components/test_runner/...
File components/test_runner/test_runner.h (right):

https://codereview.chromium.org/1807733002/diff/20001/components/test_runner/...
components/test_runner/test_runner.h:817:
scoped_ptr<MockScreenOrientationClient> mock_screen_orientation_client_;
TestRunner's lifetime is longer than the lifetime of WebTestProxy so it seems
fine to move ownership of this mock here.  This is also consistent with the plan
to replace WebTestProxyBase with exposing borrower WebFrame/View/WidgetClient
pointers out of TestRunner (see
https://docs.google.com/document/d/1Q-1uc_vCcMhPiH0NViAEVzJmSJT8Cs2YT1QDaVNM6...).

https://codereview.chromium.org/1807733002/diff/20001/components/test_runner/...
File components/test_runner/web_test_proxy.cc (right):

https://codereview.chromium.org/1807733002/diff/20001/components/test_runner/...
components/test_runner/web_test_proxy.cc:612: if (mock_client->IsDisabled())
This is a slightly different condition than before (because now mock_client is
always non-null), but
1) Previously the existance, non-nullness of screen_orientation_client_
   would depend on previous occurence of WebFrameClient (or WebFrameTestProxy)
   webScreenOrientationClient method.  This seems more fragile, than only
   depending on flags directly calls by tests (i.e. tests can disable by
   calling testRunner.disableMockScreenOrientation() from javascript).
2) Tests pass on the trybots.

[jochen (gone - plz use gerrit), 2016-03-17 19:50:13]

lgtm

[Łukasz Anforowicz, 2016-03-17 20:46:31]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-03-17 20:47:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 20:47:11]

This CL has an open dependency (Issue 1807643002 Patch 40001). Please resolve
the dependency and try again.

[Łukasz Anforowicz, 2016-03-17 20:58:27]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 20:59:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807733002/20001

[commit-bot: I haz the power, 2016-03-17 22:21:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 22:21:40]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-03-17 22:32:56]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-03-17 22:33:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807733002/20001

[commit-bot: I haz the power, 2016-03-17 22:41:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-17 22:43:50]

Description was changed from

==========
Make MockScreenOrientationClient an internal detail of components/test_runner.

Ownership of MockScreenOrientationClient can be moved to TestRunner
(which holds ownership of other things that can be influenced by
javascript bindings).

Furthermore, TestRunner doesn't need to take a detour via
WebTestDelegate (aka BlinkTestRunner) to interact with
MockScreenOrientationClient.  This means that we can remove three
screen-orientation-related methods from WebTestDelegate.  This in turn
means that components/test_runner/mock_screen_orientation_client.h
header no longer needs to be included outside of components/test_runner.

BUG=595089
==========

to

==========
Make MockScreenOrientationClient an internal detail of components/test_runner.

Ownership of MockScreenOrientationClient can be moved to TestRunner
(which holds ownership of other things that can be influenced by
javascript bindings).

Furthermore, TestRunner doesn't need to take a detour via
WebTestDelegate (aka BlinkTestRunner) to interact with
MockScreenOrientationClient.  This means that we can remove three
screen-orientation-related methods from WebTestDelegate.  This in turn
means that components/test_runner/mock_screen_orientation_client.h
header no longer needs to be included outside of components/test_runner.

BUG=595089

Committed: https://crrev.com/6a113ae1eed99940208bef750221d2f9ff058c9b
Cr-Commit-Position: refs/heads/master@{#381814}
==========

[commit-bot: I haz the power, 2016-03-17 22:43:51]

Patchset 2 (id:??) landed as
https://crrev.com/6a113ae1eed99940208bef750221d2f9ff058c9b
Cr-Commit-Position: refs/heads/master@{#381814}