components/test_runner/test_runner.h - Issue 1805243002: Make test_runner::LayoutDumpFlags an internal detail of components/test_runner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/test_runner.h

Issue 1805243002: Make test_runner::LayoutDumpFlags an internal detail of components/test_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-mock-screen-orientation-dep

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/test_runner/test_runner.h

diff --git a/components/test_runner/test_runner.h b/components/test_runner/test_runner.h

index 8abc27b50b8e286305bba22dbcd3ac8ba6265147..d4f3ed99bc7f7a72978c139e7c76dced2b670da3 100644

--- a/components/test_runner/test_runner.h

+++ b/components/test_runner/test_runner.h

@@ -73,7 +73,8 @@ class TestRunner : public WebTestRunner,

bool ShouldGeneratePixelResults() override;

bool ShouldDumpAsAudio() const override;

void GetAudioData(std::vector<unsigned char>* buffer_view) const override;

- const LayoutDumpFlags& GetLayoutDumpFlags() override;

+ bool IsRecursiveLayoutDumpRequested() override;

+ std::string DumpLayout(blink::WebLocalFrame* frame) override;

void ReplicateLayoutDumpFlagsChanges(

const base::DictionaryValue& changed_values) override;

bool HasCustomTextDump(std::string* custom_text_dump) const override;

« no previous file with comments | « no previous file | components/test_runner/test_runner.cc » ('j') | no next file with comments »