Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 1805243002: Make test_runner::LayoutDumpFlags an internal detail of components/test_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-mock-screen-orientation-dep
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/layout_test/blink_test_runner.cc
diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc
index 758d945386f449085892f41e38e5529c68ebe3c2..9d7ba8f7a9767778fd3ea235bb2a5ea3e025290d 100644
--- a/content/shell/renderer/layout_test/blink_test_runner.cc
+++ b/content/shell/renderer/layout_test/blink_test_runner.cc
@@ -30,8 +30,6 @@
#include "build/build_config.h"
#include "components/plugins/renderer/plugin_placeholder.h"
#include "components/test_runner/gamepad_controller.h"
-#include "components/test_runner/layout_dump.h"
-#include "components/test_runner/layout_dump_flags.h"
#include "components/test_runner/test_interfaces.h"
#include "components/test_runner/web_task.h"
#include "components/test_runner/web_test_interfaces.h"
@@ -885,11 +883,9 @@ void BlinkTestRunner::CaptureDump() {
return;
}
- const test_runner::LayoutDumpFlags& layout_dump_flags =
- interfaces->TestRunner()->GetLayoutDumpFlags();
- if (!layout_dump_flags.dump_child_frames()) {
- std::string layout_dump = DumpLayout(
- render_view()->GetMainRenderFrame()->GetWebFrame(), layout_dump_flags);
+ if (!interfaces->TestRunner()->IsRecursiveLayoutDumpRequested()) {
+ std::string layout_dump = interfaces->TestRunner()->DumpLayout(
+ render_view()->GetMainRenderFrame()->GetWebFrame());
OnLayoutDumpCompleted(layout_dump);
return;
}
« no previous file with comments | « components/test_runner/web_test_runner.h ('k') | content/shell/renderer/layout_test/layout_test_render_frame_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698