Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1805753002: Make test_runner::WebTask an internal detail of components/test_runner. (Closed)

Created:
4 years, 9 months ago by Łukasz Anforowicz
Modified:
4 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-layout-dump-flags-dep
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make test_runner::WebTask an internal detail of components/test_runner. We can expose test_runner::WebTask as blink::WebTaskRunner::Task. Doing this means that components/test_runner/web_task.h header no longer needs to be included outside of components/test_runner. BUG=595089 Committed: https://crrev.com/3cbe3f8b30b3eda644b1fef73f88185375101731 Cr-Commit-Position: refs/heads/master@{#381826}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -28 lines) Patch
M components/test_runner/mock_web_speech_recognizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/web_task.h View 2 chunks +4 lines, -3 lines 0 comments Download
M components/test_runner/web_test_delegate.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 3 chunks +4 lines, -20 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
Łukasz Anforowicz
jochen@, can you please take a look? https://codereview.chromium.org/1805753002/diff/1/content/shell/renderer/layout_test/blink_test_runner.cc File content/shell/renderer/layout_test/blink_test_runner.cc (left): https://codereview.chromium.org/1805753002/diff/1/content/shell/renderer/layout_test/blink_test_runner.cc#oldcode33 content/shell/renderer/layout_test/blink_test_runner.cc:33: #include "components/test_runner/test_interfaces.h" ...
4 years, 9 months ago (2016-03-16 01:41:22 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-17 19:53:01 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805753002/1
4 years, 9 months ago (2016-03-17 20:59:08 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 22:50:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805753002/1
4 years, 9 months ago (2016-03-17 23:02:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 23:08:13 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 23:10:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cbe3f8b30b3eda644b1fef73f88185375101731
Cr-Commit-Position: refs/heads/master@{#381826}

Powered by Google App Engine
This is Rietveld 408576698