[Extensions] Refactor extension action execution

[Extensions] Refactor extension action execution

Move most of the logic for extension action execution into the
ExtensionActionRunner (instead of the ExtensionActionAPI), which
eliminates some of the back-and-forth and makes a more common place
for execution logic and adds slightly finer-grained control for
what to execute. This also becomes more important with upcoming
changes for webRequest/document_start handling.

BUG=595087
Committed: https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69
Cr-Commit-Position: refs/heads/master@{#381603}

[Devlin, 2016-03-16 13:16:21]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-03-16 13:16:27]

Patchset #1 (id:20001) has been deleted

[Devlin, 2016-03-16 13:16:34]

Patchset #1 (id:40001) has been deleted

[Devlin, 2016-03-16 13:16:39]

Patchset #1 (id:60001) has been deleted

[Devlin, 2016-03-16 13:18:21]

Description was changed from

==========
[Extensions] Refactor extension action execution
BUG=
==========

to

==========
[Extensions] Refactor extension action execution

Move most of the logic for extension action execution into the
ExtensionActionRunner (instead of the ExtensionActionAPI), which
eliminates some of the back-and-forth and makes a more common place
for execution logic. This also becomes more important with upcoming
changes for webRequest/document_start handling.

BUG=595087
==========

[Devlin, 2016-03-16 13:20:46]

Description was changed from

==========
[Extensions] Refactor extension action execution

Move most of the logic for extension action execution into the
ExtensionActionRunner (instead of the ExtensionActionAPI), which
eliminates some of the back-and-forth and makes a more common place
for execution logic. This also becomes more important with upcoming
changes for webRequest/document_start handling.

BUG=595087
==========

to

==========
[Extensions] Refactor extension action execution

Move most of the logic for extension action execution into the
ExtensionActionRunner (instead of the ExtensionActionAPI), which
eliminates some of the back-and-forth and makes a more common place
for execution logic and adds slightly finer-grained control for
what to execute. This also becomes more important with upcoming
changes for webRequest/document_start handling.

BUG=595087
==========

[Devlin, 2016-03-16 13:21:15]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[Devlin, 2016-03-16 13:21:16]

Antony, can you take a look?  Predominantly copy-paste-rename.

https://codereview.chromium.org/1804123003/diff/80001/chrome/browser/extensio...
File chrome/browser/extensions/api/extension_action/extension_action_api.cc
(left):

https://codereview.chromium.org/1804123003/diff/80001/chrome/browser/extensio...
chrome/browser/extensions/api/extension_action/extension_action_api.cc:173:
ExtensionAction::ShowAction ExtensionActionAPI::ExecuteExtensionAction(
Pretty much just moved to ExtensionActionRunner::RunAction()

https://codereview.chromium.org/1804123003/diff/80001/chrome/browser/extensio...
File chrome/browser/extensions/api/extension_action/extension_action_api.cc
(right):

https://codereview.chromium.org/1804123003/diff/80001/chrome/browser/extensio...
chrome/browser/extensions/api/extension_action/extension_action_api.cc:216: void
ExtensionActionAPI::DispatchExtensionActionClicked(
Copy-paste from ExtensionActionExecuted() below

[asargent_no_longer_on_chrome, 2016-03-16 20:26:31]

lgtm

[Devlin, 2016-03-17 00:18:26]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-03-17 00:18:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1804123003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1804123003/80001

[commit-bot: I haz the power, 2016-03-17 00:25:03]

Description was changed from

==========
[Extensions] Refactor extension action execution

Move most of the logic for extension action execution into the
ExtensionActionRunner (instead of the ExtensionActionAPI), which
eliminates some of the back-and-forth and makes a more common place
for execution logic and adds slightly finer-grained control for
what to execute. This also becomes more important with upcoming
changes for webRequest/document_start handling.

BUG=595087
==========

to

==========
[Extensions] Refactor extension action execution

Move most of the logic for extension action execution into the
ExtensionActionRunner (instead of the ExtensionActionAPI), which
eliminates some of the back-and-forth and makes a more common place
for execution logic and adds slightly finer-grained control for
what to execute. This also becomes more important with upcoming
changes for webRequest/document_start handling.

BUG=595087
==========

[commit-bot: I haz the power, 2016-03-17 00:25:04]

Committed patchset #1 (id:80001)

[commit-bot: I haz the power, 2016-03-17 00:26:06]

Description was changed from

==========
[Extensions] Refactor extension action execution

Move most of the logic for extension action execution into the
ExtensionActionRunner (instead of the ExtensionActionAPI), which
eliminates some of the back-and-forth and makes a more common place
for execution logic and adds slightly finer-grained control for
what to execute. This also becomes more important with upcoming
changes for webRequest/document_start handling.

BUG=595087
==========

to

==========
[Extensions] Refactor extension action execution

Move most of the logic for extension action execution into the
ExtensionActionRunner (instead of the ExtensionActionAPI), which
eliminates some of the back-and-forth and makes a more common place
for execution logic and adds slightly finer-grained control for
what to execute. This also becomes more important with upcoming
changes for webRequest/document_start handling.

BUG=595087

Committed: https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69
Cr-Commit-Position: refs/heads/master@{#381603}
==========

[commit-bot: I haz the power, 2016-03-17 00:26:07]

Patchset 1 (id:??) landed as
https://crrev.com/343fd10c4026a7bffc366dbba98196c50903cd69
Cr-Commit-Position: refs/heads/master@{#381603}