chrome/browser/extensions/api/web_request/web_request_apitest.cc - Issue 1804123003: [Extensions] Refactor extension action execution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_apitest.cc

Issue 1804123003: [Extensions] Refactor extension action execution (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/web_request/web_request_apitest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_apitest.cc b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

index 5ac6f8c8a548e2b2332fd696350b3f21c96676aa..15458a5c2396fa6c919c4b05682295a55c37165c 100644

--- a/chrome/browser/extensions/api/web_request/web_request_apitest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

@@ -527,7 +527,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest,

// Grant activeTab permission, and perform another XHR. The extension should

// receive the event.

EXPECT_EQ(BLOCKED_ACTION_WEB_REQUEST, runner->GetBlockedActions(extension));

- runner->OnClicked(extension);

+ runner->RunAction(extension, true);

EXPECT_EQ(BLOCKED_ACTION_NONE, runner->GetBlockedActions(extension));

PerformXhrInPage(web_contents, kHost, port, kXhrPath);

EXPECT_EQ(1, GetWebRequestCountFromBackgroundPage(extension, profile()));