chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc - Issue 1804123003: [Extensions] Refactor extension action execution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc

Issue 1804123003: [Extensions] Refactor extension action execution (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/extension_action/extension_action_api.cc ('K') | « chrome/browser/ui/extensions/extension_action_view_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc

diff --git a/chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc b/chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc

index 0900274da6ecd97e545de5dee0709c2f3352441a..cc4a2aa7e2e857aa68abebd3d8a19b1aa2eaa6b8 100644

--- a/chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc

+++ b/chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc

@@ -141,7 +141,7 @@ TEST_P(ToolbarActionsBarRedesignUnitTest, ExtensionActionBlockedActions) {

EXPECT_FALSE(image_source->paint_page_action_decoration());

EXPECT_TRUE(image_source->paint_blocked_actions_decoration());

- action_runner->OnClicked(browser_action_ext.get());

+ action_runner->RunBlockedActions(browser_action_ext.get());

image_source =

browser_action->GetIconImageSourceForTesting(web_contents, kSize);

EXPECT_FALSE(image_source->grayscale());

@@ -191,7 +191,7 @@ TEST_P(ToolbarActionsBarRedesignUnitTest, ExtensionActionBlockedActions) {

web_contents, false);

toolbar_model()->SetVisibleIconCount(2u);

- action_runner->OnClicked(page_action_ext.get());

+ action_runner->RunBlockedActions(page_action_ext.get());

image_source = page_action->GetIconImageSourceForTesting(web_contents, kSize);

EXPECT_TRUE(image_source->grayscale());

EXPECT_FALSE(image_source->paint_page_action_decoration());