chrome/browser/extensions/error_console/error_console_browsertest.cc - Issue 1804123003: [Extensions] Refactor extension action execution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/error_console/error_console_browsertest.cc

Issue 1804123003: [Extensions] Refactor extension action execution (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/extension_action/extension_action_api.cc ('K') | « chrome/browser/extensions/api/web_request/web_request_apitest.cc ('k') | chrome/browser/extensions/extension_action_runner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/error_console/error_console_browsertest.cc

diff --git a/chrome/browser/extensions/error_console/error_console_browsertest.cc b/chrome/browser/extensions/error_console/error_console_browsertest.cc

index 02f406804678e5cd4cee79a4465322724bb12da6..13dfe0d2a82492eb409b0d9771815bd0e429d763 100644

--- a/chrome/browser/extensions/error_console/error_console_browsertest.cc

+++ b/chrome/browser/extensions/error_console/error_console_browsertest.cc

@@ -12,9 +12,10 @@

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

#include "build/build_config.h"

-#include "chrome/browser/extensions/api/extension_action/extension_action_api.h"

+#include "chrome/browser/extensions/extension_action_runner.h"

#include "chrome/browser/extensions/extension_browsertest.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

#include "chrome/test/base/ui_test_utils.h"

@@ -251,8 +252,9 @@ class ErrorConsoleBrowserTest : public ExtensionBrowserTest {

break;

}

case ACTION_BROWSER_ACTION: {

- ExtensionActionAPI::Get(profile())->ExecuteExtensionAction(

- *extension, browser(), true);

+ ExtensionActionRunner::GetForWebContents(

+ browser()->tab_strip_model()->GetActiveWebContents())

+ ->RunAction(*extension, true);

break;

}

case ACTION_NEW_TAB: {