[Extensions] Refactor extension action execution

chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/run_loop.h"
 #include "chrome/browser/extensions/extension_action_runner.h"
 #include "chrome/browser/ui/extensions/extension_action_view_controller.h"
 #include "chrome/browser/ui/extensions/icon_with_badge_image_source.h"
@@ skipping 123 matching lines @@
   ASSERT_TRUE(action_runner);
   action_runner->RequestScriptInjectionForTesting(
       browser_action_ext.get(), extensions::UserScript::DOCUMENT_IDLE,
       base::Bind(&base::DoNothing));
   image_source =
       browser_action->GetIconImageSourceForTesting(web_contents, kSize);
   EXPECT_FALSE(image_source->grayscale());
   EXPECT_FALSE(image_source->paint_page_action_decoration());
   EXPECT_TRUE(image_source->paint_blocked_actions_decoration());
 
-  action_runner->OnClicked(browser_action_ext.get());
+  action_runner->RunBlockedActions(browser_action_ext.get());
   image_source =
       browser_action->GetIconImageSourceForTesting(web_contents, kSize);
   EXPECT_FALSE(image_source->grayscale());
   EXPECT_FALSE(image_source->paint_page_action_decoration());
   EXPECT_FALSE(image_source->paint_blocked_actions_decoration());
 
   scoped_refptr<const extensions::Extension> page_action_ext =
       CreateAndAddExtension(
           "page action", extensions::extension_action_test_util::PAGE_ACTION);
   ASSERT_EQ(2u, toolbar_actions_bar()->GetIconCount());
@@ skipping 29 matching lines @@
   image_source =
       overflow_page_action->GetIconImageSourceForTesting(web_contents, kSize);
   EXPECT_FALSE(image_source->grayscale());
   EXPECT_FALSE(image_source->paint_page_action_decoration());
   EXPECT_TRUE(image_source->paint_blocked_actions_decoration());
 
   SetActionWantsToRunOnTab(overflow_page_action->extension_action(),
                            web_contents, false);
   toolbar_model()->SetVisibleIconCount(2u);
 
-  action_runner->OnClicked(page_action_ext.get());
+  action_runner->RunBlockedActions(page_action_ext.get());
   image_source = page_action->GetIconImageSourceForTesting(web_contents, kSize);
   EXPECT_TRUE(image_source->grayscale());
   EXPECT_FALSE(image_source->paint_page_action_decoration());
   EXPECT_FALSE(image_source->paint_blocked_actions_decoration());
 }
 
 TEST_P(ToolbarActionsBarRedesignUnitTest, ExtensionActionContextMenu) {
   CreateAndAddExtension("extension",
                         extensions::extension_action_test_util::BROWSER_ACTION);
   EXPECT_EQ(1u, toolbar_actions_bar()->GetIconCount());
@@ skipping 20 matching lines @@
   check_visibility_string(overflow_bar()->GetActions()[0],
                           IDS_EXTENSIONS_SHOW_BUTTON_IN_TOOLBAR);
   base::RunLoop run_loop;
   toolbar_actions_bar()->PopOutAction(toolbar_actions_bar()->GetActions()[0],
                                       false,
                                       run_loop.QuitClosure());
   run_loop.Run();
   check_visibility_string(toolbar_actions_bar()->GetActions()[0],
                           IDS_EXTENSIONS_KEEP_BUTTON_IN_TOOLBAR);
 }