Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1803763002: Finish conversion to sk_sp<SkShader> (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -105 lines) Patch
M bench/AlternatingColorPatternBench.cpp View 5 chunks +8 lines, -13 lines 0 comments Download
M bench/ColorCubeBench.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M bench/GameBench.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M bench/GradientBench.cpp View 5 chunks +41 lines, -47 lines 0 comments Download
M bench/ImageFilterCollapse.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M bench/PatchBench.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M bench/PatchGridBench.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M bench/RectBench.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M bench/RepeatTileBench.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M bench/TileBench.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M example/HelloWorld.cpp View 2 chunks +5 lines, -11 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkShader.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1803763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1803763002/20001
4 years, 9 months ago (2016-03-14 18:34:00 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/15c3a0e55bd9134dace0ace2fffb855a0f09542f
4 years, 9 months ago (2016-03-14 18:43:03 UTC) #6
reed1
4 years, 9 months ago (2016-03-14 18:52:54 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1798133003/ by reed@google.com.

The reason for reverting is: need to update cmake build example.

Powered by Google App Engine
This is Rietveld 408576698