Issue 180243014: Revert "Revert 253606 "Revert 251238 "cc: Clean up iterator template to ...""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180243014: Revert "Revert 253606 "Revert 251238 "cc: Clean up iterator template to ..."" (Closed)

Created:
6 years, 10 months ago by danakj

Modified:
6 years, 10 months ago

Reviewers:

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert "Revert 253606 "Revert 251238 "cc: Clean up iterator template to ..."" Speculative revert to see if this affects memory stomping behaviours. BUG=345757 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253612

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+252 lines, -99 lines)			Patch
M	cc/cc.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/debug/debug_rect_history.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	cc/layers/layer_iterator.h	View	7 chunks	+57 lines, -75 lines	0 comments	Download
A	cc/layers/layer_iterator.cc	View	1 chunk	+130 lines, -0 lines	0 comments	Download
M	cc/layers/layer_iterator_unittest.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	cc/layers/render_surface.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	cc/layers/render_surface_impl.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	cc/trees/layer_tree_host.cc	View	3 chunks	+12 lines, -4 lines	0 comments	Download
M	cc/trees/layer_tree_host_common.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	cc/trees/layer_tree_host_impl.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	cc/trees/layer_tree_impl.cc	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	cc/trees/occlusion_tracker_perftest.cc	View	2 chunks	+12 lines, -4 lines	0 comments	Download
M	cc/trees/occlusion_tracker_unittest.cc	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	cc/trees/quad_culler_unittest.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

danakj

6 years, 10 months ago (2014-02-26 22:46:37 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r253612 (tree was closed).