Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1798133003: Revert of Finish conversion to sk_sp<SkShader> (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Finish conversion to sk_sp<SkShader> (patchset #2 id:20001 of https://codereview.chromium.org/1803763002/ ) Reason for revert: need to update cmake build example Original issue's description: > Finish conversion to sk_sp<SkShader> > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1803763002 > > TBR= > > Committed: https://skia.googlesource.com/skia/+/15c3a0e55bd9134dace0ace2fffb855a0f09542f TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/106e10ddff5d473dc81dd1ce8ade615585ea609b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -96 lines) Patch
M bench/AlternatingColorPatternBench.cpp View 5 chunks +13 lines, -8 lines 0 comments Download
M bench/ColorCubeBench.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M bench/GameBench.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M bench/GradientBench.cpp View 5 chunks +66 lines, -60 lines 0 comments Download
M bench/ImageFilterCollapse.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M bench/PatchBench.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M bench/PatchGridBench.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M bench/RectBench.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M bench/RepeatTileBench.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M bench/TileBench.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M example/HelloWorld.cpp View 2 chunks +11 lines, -5 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkShader.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Revert of Finish conversion to sk_sp<SkShader>
4 years, 9 months ago (2016-03-14 18:52:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798133003/1
4 years, 9 months ago (2016-03-14 18:53:00 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 18:53:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/106e10ddff5d473dc81dd1ce8ade615585ea609b

Powered by Google App Engine
This is Rietveld 408576698