PlzNavigate: fix two RenderViewImplTests related to history

PlzNavigate: fix two RenderViewImplTests related to history

This CL fixes
RenderViewImplTest.BrowserNavigationStartNotUsedForHistoryNavigation and
RenderViewImplTest.TestBackForward. Properly simulatin ghistory navigations
with PlzNavigate enabled requires providing a url in the
CommonNavigationParams, which was not being done.

BUG=475027
Committed: https://crrev.com/2c11358348eb568cfddf14ef7c7c7b891607e148
Cr-Commit-Position: refs/heads/master@{#382940}

[clamy, 2016-03-18 15:23:16]

Description was changed from

==========
PlzNavigate: fix two RenderViewImplTests related to history

This CL fixes
RenderViewImplTest.BrowserNavigationStartNotUsedForHistoryNavigation and
RenderViewImplTest.TestBackForward. Properly simulatin ghistory navigations
with PlzNavigate enabled requires providing a url in the
CommonNavigationParams, which was not being done.

BUG=475027
==========

to

==========
PlzNavigate: fix two RenderViewImplTests related to history

This CL fixes
RenderViewImplTest.BrowserNavigationStartNotUsedForHistoryNavigation and
RenderViewImplTest.TestBackForward. Properly simulatin ghistory navigations
with PlzNavigate enabled requires providing a url in the
CommonNavigationParams, which was not being done.

BUG=475027
==========

[clamy, 2016-03-18 15:23:16]

clamy@chromium.org changed reviewers:
+ nasko@chromium.org

[clamy, 2016-03-18 15:23:29]

@nasko: PTAL

[nasko, 2016-03-18 15:56:17]

nasko@chromium.org changed reviewers:
+ creis@chromium.org

[nasko, 2016-03-18 15:56:18]

Hey Charlie,
Can you also take a look at this CL? It is history related.
Thanks!
Nasko

[Charlie Reis, 2016-03-18 17:43:23]

https://codereview.chromium.org/1797393008/diff/1/content/renderer/render_vie...
File content/renderer/render_view_browsertest.cc (left):

https://codereview.chromium.org/1797393008/diff/1/content/renderer/render_vie...
content/renderer/render_view_browsertest.cc:1459: GoBack(back_state);
Why not update GoBack itself (in RenderViewTest) by passing in a URL along with
the PageState?  That would probably let you fix
ChromeRenderViewTest.BackToTranslatablePage as well.

https://codereview.chromium.org/1797393008/diff/1/content/renderer/render_vie...
content/renderer/render_view_browsertest.cc:1465: GoForward(forward_state);
Same here.

[clamy, 2016-03-23 15:23:08]

Thanks!

https://codereview.chromium.org/1797393008/diff/1/content/renderer/render_vie...
File content/renderer/render_view_browsertest.cc (left):

https://codereview.chromium.org/1797393008/diff/1/content/renderer/render_vie...
content/renderer/render_view_browsertest.cc:1459: GoBack(back_state);
On 2016/03/18 17:43:23, Charlie Reis wrote:
> Why not update GoBack itself (in RenderViewTest) by passing in a URL along
with
> the PageState?  That would probably let you fix
> ChromeRenderViewTest.BackToTranslatablePage as well.

Done.

https://codereview.chromium.org/1797393008/diff/1/content/renderer/render_vie...
content/renderer/render_view_browsertest.cc:1465: GoForward(forward_state);
On 2016/03/18 17:43:23, Charlie Reis wrote:
> Same here.

Done.

[Charlie Reis, 2016-03-23 18:11:13]

Thanks!  LGTM.

[Charlie Reis, 2016-03-23 18:11:52]

On 2016/03/23 18:11:13, Charlie Reis wrote:
> Thanks!  LGTM.

I'm running a linux_site_isolation try job just to be sure, and then I'll plan
to CQ it.

[Charlie Reis, 2016-03-23 18:52:41]

creis@chromium.org changed reviewers:
+ sky@chromium.org

[Charlie Reis, 2016-03-23 18:52:41]

Also, +sky for chrome/ OWNERs on the test file.

[sky, 2016-03-23 21:33:33]

https://codereview.chromium.org/1797393008/diff/40001/content/public/test/ren...
File content/public/test/render_view_test.h (right):

https://codereview.chromium.org/1797393008/diff/40001/content/public/test/ren...
content/public/test/render_view_test.h:106: void GoBack(const GURL& url, const
PageState& state);
Seems bizarre that goback/forward take a url. Don't we know the url?

[Charlie Reis, 2016-03-23 21:51:15]

https://codereview.chromium.org/1797393008/diff/40001/content/public/test/ren...
File content/public/test/render_view_test.h (right):

https://codereview.chromium.org/1797393008/diff/40001/content/public/test/ren...
content/public/test/render_view_test.h:106: void GoBack(const GURL& url, const
PageState& state);
On 2016/03/23 21:33:32, sky wrote:
> Seems bizarre that goback/forward take a url. Don't we know the url?

I think it's serialized inside the PageState.  I'm hoping to make PageState be
less opaque as I move it to be more of a FrameState, which would make it easier
to avoid passing the URL here.

I suppose we could crack open the PageState inside the test function in the
meantime; it's just a bit of a hassle.

[sky, 2016-03-23 21:55:12]

Ok, LGTM

[Charlie Reis, 2016-03-23 22:05:42]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2016-03-23 22:06:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1797393008/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1797393008/40001

[commit-bot: I haz the power, 2016-03-23 22:13:55]

Description was changed from

==========
PlzNavigate: fix two RenderViewImplTests related to history

This CL fixes
RenderViewImplTest.BrowserNavigationStartNotUsedForHistoryNavigation and
RenderViewImplTest.TestBackForward. Properly simulatin ghistory navigations
with PlzNavigate enabled requires providing a url in the
CommonNavigationParams, which was not being done.

BUG=475027
==========

to

==========
PlzNavigate: fix two RenderViewImplTests related to history

This CL fixes
RenderViewImplTest.BrowserNavigationStartNotUsedForHistoryNavigation and
RenderViewImplTest.TestBackForward. Properly simulatin ghistory navigations
with PlzNavigate enabled requires providing a url in the
CommonNavigationParams, which was not being done.

BUG=475027
==========

[commit-bot: I haz the power, 2016-03-23 22:13:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-23 22:15:09]

Description was changed from

==========
PlzNavigate: fix two RenderViewImplTests related to history

This CL fixes
RenderViewImplTest.BrowserNavigationStartNotUsedForHistoryNavigation and
RenderViewImplTest.TestBackForward. Properly simulatin ghistory navigations
with PlzNavigate enabled requires providing a url in the
CommonNavigationParams, which was not being done.

BUG=475027
==========

to

==========
PlzNavigate: fix two RenderViewImplTests related to history

This CL fixes
RenderViewImplTest.BrowserNavigationStartNotUsedForHistoryNavigation and
RenderViewImplTest.TestBackForward. Properly simulatin ghistory navigations
with PlzNavigate enabled requires providing a url in the
CommonNavigationParams, which was not being done.

BUG=475027

Committed: https://crrev.com/2c11358348eb568cfddf14ef7c7c7b891607e148
Cr-Commit-Position: refs/heads/master@{#382940}
==========

[commit-bot: I haz the power, 2016-03-23 22:15:10]

Patchset 3 (id:??) landed as
https://crrev.com/2c11358348eb568cfddf14ef7c7c7b891607e148
Cr-Commit-Position: refs/heads/master@{#382940}