Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2115)

Unified Diff: content/public/test/render_view_test.cc

Issue 1797393008: PlzNavigate: fix two RenderViewImplTests related to history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/render_view_test.cc
diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc
index 572e008dd2e9225a3e7c4c9cdfda8be38b2064e3..b9e869f2cdfe003282d75794d30ea13dce7d13bb 100644
--- a/content/public/test/render_view_test.cc
+++ b/content/public/test/render_view_test.cc
@@ -280,12 +280,12 @@ PageState RenderViewTest::GetCurrentPageState() {
}
}
-void RenderViewTest::GoBack(const PageState& state) {
- GoToOffset(-1, state);
+void RenderViewTest::GoBack(const GURL& url, const PageState& state) {
+ GoToOffset(-1, url, state);
}
-void RenderViewTest::GoForward(const PageState& state) {
- GoToOffset(1, state);
+void RenderViewTest::GoForward(const GURL& url, const PageState& state) {
+ GoToOffset(1, url, state);
}
void RenderViewTest::SetUp() {
@@ -697,7 +697,9 @@ scoped_ptr<ResizeParams> RenderViewTest::InitialSizeParams() {
return make_scoped_ptr(new ResizeParams());
}
-void RenderViewTest::GoToOffset(int offset, const PageState& state) {
+void RenderViewTest::GoToOffset(int offset,
+ const GURL& url,
+ const PageState& state) {
RenderViewImpl* impl = static_cast<RenderViewImpl*>(view_);
int history_list_length = impl->historyBackListCount() +
@@ -705,7 +707,7 @@ void RenderViewTest::GoToOffset(int offset, const PageState& state) {
int pending_offset = offset + impl->history_list_offset_;
CommonNavigationParams common_params(
- GURL(), Referrer(), ui::PAGE_TRANSITION_FORWARD_BACK,
+ url, Referrer(), ui::PAGE_TRANSITION_FORWARD_BACK,
FrameMsg_Navigate_Type::NORMAL, true, false, base::TimeTicks(),
FrameMsg_UILoadMetricsReportType::NO_REPORT, GURL(), GURL(),
LOFI_UNSPECIFIED, base::TimeTicks::Now(), "GET");

Powered by Google App Engine
This is Rietveld 408576698