PlzNavigate: fix two RenderViewImplTests related to history

content/public/test/render_view_test.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_TEST_RENDER_VIEW_TEST_H_
 #define CONTENT_PUBLIC_TEST_RENDER_VIEW_TEST_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 85 matching lines @@
   // instead of LoadHTML for tests that cannot use a data: url (for example if
   // document.location needs to be set to something specific.)
   void LoadHTMLWithUrlOverride(const char* html, const char* url);
 
   // Returns the current PageState.
   // In OOPIF enabled modes, this returns a PageState object for the main frame.
   PageState GetCurrentPageState();
 
   // Navigates the main frame back or forward in session history and commits.
   // The caller must capture a PageState for the target page.
-  void GoBack(const PageState& state);
-  void GoForward(const PageState& state);
+  void GoBack(const GURL& url, const PageState& state);

[sky, 2016/03/23 21:33:32]

Seems bizarre that goback/forward take a url. Don't we know the url?

[Charlie Reis, 2016/03/23 21:51:14]

I think it's serialized inside the PageState.  I'm hoping to make PageState be
less opaque as I move it to be more of a FrameState, which would make it easier
to avoid passing the URL here.

I suppose we could crack open the PageState inside the test function in the
meantime; it's just a bit of a hassle.

+  void GoForward(const GURL& url, const PageState& state);
 
   // Sends one native key event over IPC.
   void SendNativeKeyEvent(const NativeWebKeyboardEvent& key_event);
 
   // Send a raw keyboard event to the renderer.
   void SendWebKeyboardEvent(const blink::WebKeyboardEvent& key_event);
 
   // Send a raw mouse event to the renderer.
   void SendWebMouseEvent(const blink::WebMouseEvent& mouse_event);
 
@@ skipping 88 matching lines @@
 
   // For Mojo.
   scoped_ptr<base::TestIOThread> test_io_thread_;
   scoped_ptr<mojo::edk::test::ScopedIPCSupport> ipc_support_;
 
 #if defined(OS_MACOSX)
   scoped_ptr<base::mac::ScopedNSAutoreleasePool> autorelease_pool_;
 #endif
 
  private:
-  void GoToOffset(int offset, const PageState& state);
+  void GoToOffset(int offset, const GURL& url, const PageState& state);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_TEST_RENDER_VIEW_TEST_H_