Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1547)

Unified Diff: content/public/test/render_view_test.h

Issue 1797393008: PlzNavigate: fix two RenderViewImplTests related to history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/translate/translate_helper_browsertest.cc ('k') | content/public/test/render_view_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/render_view_test.h
diff --git a/content/public/test/render_view_test.h b/content/public/test/render_view_test.h
index 3c3b3f8c07b2e3dcc530f4cda357956e930bbe25..7fb7653230eb029c6ae463855ca2c7e04f12798d 100644
--- a/content/public/test/render_view_test.h
+++ b/content/public/test/render_view_test.h
@@ -103,8 +103,8 @@ class RenderViewTest : public testing::Test, blink::WebLeakDetectorClient {
// Navigates the main frame back or forward in session history and commits.
// The caller must capture a PageState for the target page.
- void GoBack(const PageState& state);
- void GoForward(const PageState& state);
+ void GoBack(const GURL& url, const PageState& state);
sky 2016/03/23 21:33:32 Seems bizarre that goback/forward take a url. Don'
Charlie Reis 2016/03/23 21:51:14 I think it's serialized inside the PageState. I'm
+ void GoForward(const GURL& url, const PageState& state);
// Sends one native key event over IPC.
void SendNativeKeyEvent(const NativeWebKeyboardEvent& key_event);
@@ -213,7 +213,7 @@ class RenderViewTest : public testing::Test, blink::WebLeakDetectorClient {
#endif
private:
- void GoToOffset(int offset, const PageState& state);
+ void GoToOffset(int offset, const GURL& url, const PageState& state);
};
} // namespace content
« no previous file with comments | « chrome/renderer/translate/translate_helper_browsertest.cc ('k') | content/public/test/render_view_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698