Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Side by Side Diff: content/renderer/render_view_browsertest.cc

Issue 1797393008: PlzNavigate: fix two RenderViewImplTests related to history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 1438 matching lines...) Expand 10 before | Expand all | Expand 10 after
1449 1449
1450 LoadHTML("<div id=pagename>Page C</div>"); 1450 LoadHTML("<div id=pagename>Page C</div>");
1451 int was_page_c = -1; 1451 int was_page_c = -1;
1452 base::string16 check_page_c = 1452 base::string16 check_page_c =
1453 base::ASCIIToUTF16( 1453 base::ASCIIToUTF16(
1454 "Number(document.getElementById('pagename').innerHTML == 'Page C')"); 1454 "Number(document.getElementById('pagename').innerHTML == 'Page C')");
1455 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_c, &was_page_c)); 1455 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_c, &was_page_c));
1456 EXPECT_EQ(1, was_page_c); 1456 EXPECT_EQ(1, was_page_c);
1457 1457
1458 PageState forward_state = GetCurrentPageState(); 1458 PageState forward_state = GetCurrentPageState();
1459 GoBack(back_state); 1459
1460 // Go back.
1461 GoBack(GURL("data:text/html;charset=utf-8,<div id=pagename>Page B</div>"),
1462 back_state);
1463
1460 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_b, &was_page_b)); 1464 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_b, &was_page_b));
1461 EXPECT_EQ(1, was_page_b); 1465 EXPECT_EQ(1, was_page_b);
1462
1463 PageState back_state2 = GetCurrentPageState(); 1466 PageState back_state2 = GetCurrentPageState();
1464 1467
1465 GoForward(forward_state); 1468 // Go forward.
1469 GoForward(GURL("data:text/html;charset=utf-8,<div id=pagename>Page C</div>"),
1470 forward_state);
1466 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_c, &was_page_c)); 1471 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_c, &was_page_c));
1467 EXPECT_EQ(1, was_page_c); 1472 EXPECT_EQ(1, was_page_c);
1468 1473
1469 GoBack(back_state2); 1474 // Go back.
1475 GoBack(GURL("data:text/html;charset=utf-8,<div id=pagename>Page B</div>"),
1476 back_state2);
1470 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_b, &was_page_b)); 1477 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_b, &was_page_b));
1471 EXPECT_EQ(1, was_page_b); 1478 EXPECT_EQ(1, was_page_b);
1472 1479
1473 forward_state = GetCurrentPageState(); 1480 forward_state = GetCurrentPageState();
1474 GoBack(page_a_state); 1481
1482 // Go back.
1483 GoBack(GURL("data:text/html;charset=utf-8,<div id=pagename>Page A</div>"),
1484 page_a_state);
1475 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_a, &was_page_a)); 1485 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_a, &was_page_a));
1476 EXPECT_EQ(1, was_page_a); 1486 EXPECT_EQ(1, was_page_a);
1477 1487
1478 GoForward(forward_state); 1488 // Go forward.
1489 GoForward(GURL("data:text/html;charset=utf-8,<div id=pagename>Page B</div>"),
1490 forward_state);
1479 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_b, &was_page_b)); 1491 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_b, &was_page_b));
1480 EXPECT_EQ(1, was_page_b); 1492 EXPECT_EQ(1, was_page_b);
1481 } 1493 }
1482 1494
1483 #if defined(OS_MACOSX) || defined(USE_AURA) 1495 #if defined(OS_MACOSX) || defined(USE_AURA)
1484 TEST_F(RenderViewImplTest, GetCompositionCharacterBoundsTest) { 1496 TEST_F(RenderViewImplTest, GetCompositionCharacterBoundsTest) {
1485 #if defined(OS_WIN) 1497 #if defined(OS_WIN)
1486 // http://crbug.com/304193 1498 // http://crbug.com/304193
1487 if (base::win::GetVersion() < base::win::VERSION_VISTA) 1499 if (base::win::GetVersion() < base::win::VERSION_VISTA)
1488 return; 1500 return;
(...skipping 550 matching lines...) Expand 10 before | Expand all | Expand 10 after
2039 2051
2040 TEST_F(RenderViewImplTest, BrowserNavigationStartNotUsedForHistoryNavigation) { 2052 TEST_F(RenderViewImplTest, BrowserNavigationStartNotUsedForHistoryNavigation) {
2041 LoadHTML("<div id=pagename>Page A</div>"); 2053 LoadHTML("<div id=pagename>Page A</div>");
2042 LoadHTML("<div id=pagename>Page B</div>"); 2054 LoadHTML("<div id=pagename>Page B</div>");
2043 PageState back_state = GetCurrentPageState(); 2055 PageState back_state = GetCurrentPageState();
2044 LoadHTML("<div id=pagename>Page C</div>"); 2056 LoadHTML("<div id=pagename>Page C</div>");
2045 PageState forward_state = GetCurrentPageState(); 2057 PageState forward_state = GetCurrentPageState();
2046 ProcessPendingMessages(); 2058 ProcessPendingMessages();
2047 render_thread_->sink().ClearMessages(); 2059 render_thread_->sink().ClearMessages();
2048 2060
2049 CommonNavigationParams common_params;
2050 common_params.transition = ui::PAGE_TRANSITION_FORWARD_BACK;
2051 // Go back. 2061 // Go back.
2052 GoToOffsetWithParams(-1, back_state, common_params, StartNavigationParams(), 2062 CommonNavigationParams common_params_back;
2053 RequestNavigationParams()); 2063 common_params_back.url =
2064 GURL("data:text/html;charset=utf-8,<div id=pagename>Page B</div>");
2065 common_params_back.transition = ui::PAGE_TRANSITION_FORWARD_BACK;
2066 GoToOffsetWithParams(-1, back_state, common_params_back,
2067 StartNavigationParams(), RequestNavigationParams());
2054 FrameHostMsg_DidStartProvisionalLoad::Param host_nav_params = 2068 FrameHostMsg_DidStartProvisionalLoad::Param host_nav_params =
2055 ProcessAndReadIPC<FrameHostMsg_DidStartProvisionalLoad>(); 2069 ProcessAndReadIPC<FrameHostMsg_DidStartProvisionalLoad>();
2056 EXPECT_PRED2(TimeTicksGT, base::get<1>(host_nav_params), 2070 EXPECT_PRED2(TimeTicksGT, base::get<1>(host_nav_params),
2057 common_params.navigation_start); 2071 common_params_back.navigation_start);
2058 render_thread_->sink().ClearMessages(); 2072 render_thread_->sink().ClearMessages();
2059 2073
2060 // Go forward. 2074 // Go forward.
2061 GoToOffsetWithParams(1, forward_state, common_params, 2075 CommonNavigationParams common_params_forward;
2062 StartNavigationParams(), 2076 common_params_forward.url =
2063 RequestNavigationParams()); 2077 GURL("data:text/html;charset=utf-8,<div id=pagename>Page C</div>");
2078 common_params_forward.transition = ui::PAGE_TRANSITION_FORWARD_BACK;
2079 GoToOffsetWithParams(1, forward_state, common_params_forward,
2080 StartNavigationParams(), RequestNavigationParams());
2064 FrameHostMsg_DidStartProvisionalLoad::Param host_nav_params2 = 2081 FrameHostMsg_DidStartProvisionalLoad::Param host_nav_params2 =
2065 ProcessAndReadIPC<FrameHostMsg_DidStartProvisionalLoad>(); 2082 ProcessAndReadIPC<FrameHostMsg_DidStartProvisionalLoad>();
2066 EXPECT_PRED2(TimeTicksGT, base::get<1>(host_nav_params2), 2083 EXPECT_PRED2(TimeTicksGT, base::get<1>(host_nav_params2),
2067 common_params.navigation_start); 2084 common_params_forward.navigation_start);
2068 } 2085 }
2069 2086
2070 TEST_F(RenderViewImplTest, BrowserNavigationStartSuccessfullyTransmitted) { 2087 TEST_F(RenderViewImplTest, BrowserNavigationStartSuccessfullyTransmitted) {
2071 CommonNavigationParams common_params; 2088 CommonNavigationParams common_params;
2072 common_params.url = GURL("data:text/html,<div>Page</div>"); 2089 common_params.url = GURL("data:text/html,<div>Page</div>");
2073 common_params.navigation_type = FrameMsg_Navigate_Type::NORMAL; 2090 common_params.navigation_type = FrameMsg_Navigate_Type::NORMAL;
2074 common_params.transition = ui::PAGE_TRANSITION_TYPED; 2091 common_params.transition = ui::PAGE_TRANSITION_TYPED;
2075 2092
2076 frame()->Navigate(common_params, StartNavigationParams(), 2093 frame()->Navigate(common_params, StartNavigationParams(),
2077 RequestNavigationParams()); 2094 RequestNavigationParams());
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
2337 FROM_HERE, 2354 FROM_HERE,
2338 base::Bind(&DevToolsAgentTest::CloseWhilePaused, base::Unretained(this))); 2355 base::Bind(&DevToolsAgentTest::CloseWhilePaused, base::Unretained(this)));
2339 ExecuteJavaScriptForTests("debugger;"); 2356 ExecuteJavaScriptForTests("debugger;");
2340 2357
2341 // CloseWhilePaused should resume execution and continue here. 2358 // CloseWhilePaused should resume execution and continue here.
2342 EXPECT_FALSE(IsPaused()); 2359 EXPECT_FALSE(IsPaused());
2343 Detach(); 2360 Detach();
2344 } 2361 }
2345 2362
2346 } // namespace content 2363 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698