Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 179383003: [CSS Grid Layout] Disallow using <ident> and function names as <custom-ident> (Closed)

Created:
6 years, 9 months ago by svillar
Modified:
5 years, 1 month ago
CC:
blink-reviews, jfernandez, svillar, Manuel Rego, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Grid Layout] Disallow using <ident> and function names as <custom-ident> As mentioned in this thread http://lists.w3.org/Archives/Public/www-style/2014Feb/0734.html both "subgrid" and "auto" idents and "minmax" function should be considered as invalid <custom-idents>. This means that trying to use them as grid line names in grid-template-{columns|rows} should be considered a grammar violation making the whole declaration invalid. While updating the test cases I found that we were not setting "display:grid" in some tests, so I fixed that too.

Patch Set 1 #

Total comments: 1

Messages

Total messages: 3 (0 generated)
svillar
Updated the description, I forgot to add a title for the issue.
6 years, 9 months ago (2014-02-28 10:52:30 UTC) #1
Julien - ping for review
https://codereview.chromium.org/179383003/diff/1/Source/core/css/parser/BisonCSSParser-in.cpp File Source/core/css/parser/BisonCSSParser-in.cpp (right): https://codereview.chromium.org/179383003/diff/1/Source/core/css/parser/BisonCSSParser-in.cpp#newcode4682 Source/core/css/parser/BisonCSSParser-in.cpp:4682: || equalIgnoringCase(identValue->string, "subgrid")) subgrid will be moved to level ...
6 years, 9 months ago (2014-03-01 00:42:21 UTC) #2
svillar
5 years, 1 month ago (2015-11-12 16:07:07 UTC) #3
Message was sent while issue was closed.
Closing as this requires engine-wide actions

Powered by Google App Engine
This is Rietveld 408576698