Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set-expected.txt

Issue 179383003: [CSS Grid Layout] Disallow using <ident> and function names as <custom-ident> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set-expected.txt
diff --git a/LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set-expected.txt b/LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set-expected.txt
index aeec8e6fd534daa5138e49bca5ed163bd0bdd255..b0779df2b94fbe844db9ba9db9b4214381a62ba6 100644
--- a/LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set-expected.txt
+++ b/LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set-expected.txt
@@ -71,11 +71,19 @@ PASS element.style.gridTemplateColumns is "(foo bar) auto (foo) auto (bar)"
PASS getComputedStyle(element, '').getPropertyValue('grid-template-rows') is "(foo bar) auto (foo) auto (bar)"
PASS element.style.gridTemplateRows is "(foo bar) auto (foo) auto (bar)"
+Test getting invalid grid-template-columns and grid-template-rows set through CSS
+PASS window.getComputedStyle(gridWithAutoAsCustomIdent, '').getPropertyValue('grid-template-columns') is "none"
+PASS window.getComputedStyle(gridWithAutoAsCustomIdent, '').getPropertyValue('grid-template-rows') is "none"
+PASS window.getComputedStyle(gridWithMinmaxAsCustomIdent, '').getPropertyValue('grid-template-columns') is "none"
+PASS window.getComputedStyle(gridWithMinmaxAsCustomIdent, '').getPropertyValue('grid-template-rows') is "none"
+PASS window.getComputedStyle(gridWithSubgridAsCustomIdent, '').getPropertyValue('grid-template-columns') is "none"
+PASS window.getComputedStyle(gridWithSubgridAsCustomIdent, '').getPropertyValue('grid-template-rows') is "none"
+
Test getting and setting invalid grid-template-columns and grid-template-rows through JS
-PASS getComputedStyle(element, '').getPropertyValue('grid-template-columns') is "none"
-PASS getComputedStyle(element, '').getPropertyValue('grid-template-rows') is "none"
-PASS getComputedStyle(element, '').getPropertyValue('grid-template-columns') is "none"
-PASS getComputedStyle(element, '').getPropertyValue('grid-template-rows') is "none"
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-columns') is "none"
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-rows') is "none"
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-columns') is "none"
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-template-rows') is "none"
PASS successfullyParsed is true
TEST COMPLETE

Powered by Google App Engine
This is Rietveld 408576698