LayoutTests/fast/css-grid-layout/non-grid-element-repeat-get-set.html - Issue 179383003: [CSS Grid Layout] Disallow using <ident> and function names as <custom-ident>

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/non-grid-element-repeat-get-set.html

Issue 179383003: [CSS Grid Layout] Disallow using <ident> and function names as <custom-ident> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt ('k') | LayoutTests/fast/css-grid-layout/non-grid-element-repeat-get-set-expected.txt » ('j') | Source/core/css/parser/BisonCSSParser-in.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

2 <html>	2 <html>

3 <head>	3 <head>

4 <link href="resources/grid.css" rel="stylesheet">	4 <link href="resources/grid.css" rel="stylesheet">

5 <style>	5 <style>

6 .singleSingleTrackRepeat {	6 .singleSingleTrackRepeat {

7 grid-template-rows: repeat(1, 18px);	7 grid-template-rows: repeat(1, 18px);

8 grid-template-columns: repeat(1, 15%);	8 grid-template-columns: repeat(1, 15%);

9 }	9 }

10	10

(...skipping 73 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
84 element.style.gridTemplateColumns = gridColumn;	84 element.style.gridTemplateColumns = gridColumn;

85 shouldBeEqualToString("window.getComputedStyle(element, '').getPropertyV alue('grid-template-columns')", "none");	85 shouldBeEqualToString("window.getComputedStyle(element, '').getPropertyV alue('grid-template-columns')", "none");

86 document.body.removeChild(element);	86 document.body.removeChild(element);

87 }	87 }

88 testInvalidSyntax("repeat(");	88 testInvalidSyntax("repeat(");

89 testInvalidSyntax("repeat()");	89 testInvalidSyntax("repeat()");

90 testInvalidSyntax("repeat(3 / auto)");	90 testInvalidSyntax("repeat(3 / auto)");

91 testInvalidSyntax("repeat(3 , ,)");	91 testInvalidSyntax("repeat(3 , ,)");

92 testInvalidSyntax("repeat(0, 15px)");	92 testInvalidSyntax("repeat(0, 15px)");

93 testInvalidSyntax("repeat(-1, auto)");	93 testInvalidSyntax("repeat(-1, auto)");

	94 testInvalidSyntax("repeat(1, (auto) 10px)");

	95 testInvalidSyntax("repeat(1, (start auto) 10px)");

	96 testInvalidSyntax("repeat(1, 10px (minmax))");

	97 testInvalidSyntax("repeat(1, 10px (minmax end))");

	98 testInvalidSyntax("repeat(1, 2em (subgrid) 10px)");

	99 testInvalidSyntax("repeat(1, 2em (middle subgrid) 10px)");

94 // Nesting is no allowed.	100 // Nesting is no allowed.

95 testInvalidSyntax("repeat(2, repeat(1, auto))");	101 testInvalidSyntax("repeat(2, repeat(1, auto))");

96 </script>	102 </script>

97 </body>	103 </body>

98 </html>	104 </html>

OLD	NEW