Source/core/css/parser/CSSPropertyParser.h - Issue 179383003: [CSS Grid Layout] Disallow using <ident> and function names as <custom-ident>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSPropertyParser.h

Issue 179383003: [CSS Grid Layout] Disallow using <ident> and function names as <custom-ident> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/parser/CSSPropertyParser.h

diff --git a/Source/core/css/parser/CSSPropertyParser.h b/Source/core/css/parser/CSSPropertyParser.h

index 037b6467083ba664d8185381b29a51646373adfd..d47ad91dfa47c674f7b3728e442d690d2a24005a 100644

--- a/Source/core/css/parser/CSSPropertyParser.h

+++ b/Source/core/css/parser/CSSPropertyParser.h

@@ -156,7 +156,7 @@ private:

PassRefPtrWillBeRawPtr<CSSValue> parseGridTrackSize(CSSParserValueList& inputList);

PassRefPtrWillBeRawPtr<CSSPrimitiveValue> parseGridBreadth(CSSParserValue*);

PassRefPtrWillBeRawPtr<CSSValue> parseGridTemplateAreas();

- void parseGridLineNames(CSSParserValueList* inputList, CSSValueList&);

+ bool parseGridLineNames(CSSParserValueList* inputList, CSSValueList&);

bool parseClipShape(CSSPropertyID, bool important);

« Source/core/css/parser/BisonCSSParser-in.cpp ('K') | « Source/core/css/parser/BisonCSSParser-in.cpp ('k') | no next file » | no next file with comments »