Password update bubble UI improvement.

Password update bubble UI improvement.

When current domain and domain of saved credentials don't coincide then show update password bubbletitle as "Do you want to update password for <domain>?" instead of "Do you want to save password for <domain>?".

BUG=593034
Committed: https://crrev.com/4a9874f00efac95d9b4b21ff17ef415c0b0d8f0a
Cr-Commit-Position: refs/heads/master@{#380646}

[dvadym, 2016-03-11 12:10:27]

Description was changed from

==========
Password update bubble UI improvement.

When current domain and domain of saved credentials don't coincide then to show
update password bubbletitle as "Do you want to update password for <domain>?"
instead of "Do you want to update password for this site?".

BUG=593034
==========

to

==========
Password update bubble UI improvement.

When current domain and domain of saved credentials don't coincide then show
update password bubbletitle as "Do you want to update password for <domain>?"
instead of "Do you want to update password for this site?".

BUG=593034
==========

[dvadym, 2016-03-11 12:11:51]

dvadym@chromium.org changed reviewers:
+ vasilii@chromium.org

[dvadym, 2016-03-11 12:11:51]

Hi Vasilii,

 Could you please review this CL?

Regards,
Vadym

[vasilii, 2016-03-11 13:27:29]

lgtm

Fix the bug description. It leaves the impression that currently we show "Do you
want to update password for this site?" for the different origins.

https://codereview.chromium.org/1787653002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1787653002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:14338: +      <message
name="IDS_UPDATE_PASSWORD_TITLE" desc="The title of the update password bubble
when a password can be updated.">
I'd make both the name and the description mention the different origins case.

[dvadym, 2016-03-11 14:23:51]

Description was changed from

==========
Password update bubble UI improvement.

When current domain and domain of saved credentials don't coincide then show
update password bubbletitle as "Do you want to update password for <domain>?"
instead of "Do you want to update password for this site?".

BUG=593034
==========

to

==========
Password update bubble UI improvement.

When current domain and domain of saved credentials don't coincide then show
update password bubbletitle as "Do you want to update password for <domain>?"
instead of "Do you want to save password for <domain>?".

BUG=593034
==========

[dvadym, 2016-03-11 15:07:01]

Thanks Vasilii for review!

https://codereview.chromium.org/1787653002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1787653002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:14338: +      <message
name="IDS_UPDATE_PASSWORD_TITLE" desc="The title of the update password bubble
when a password can be updated.">
On 2016/03/11 13:27:29, vasilii wrote:
> I'd make both the name and the description mention the different origins case.

Done.

[dvadym, 2016-03-11 15:48:45]

The CQ bit was checked by dvadym@chromium.org

[dvadym, 2016-03-11 15:48:45]

The patchset sent to the CQ was uploaded after l-g-t-m from vasilii@chromium.org
Link to the patchset: https://codereview.chromium.org/1787653002/#ps20001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-03-11 15:49:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1787653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1787653002/20001

[commit-bot: I haz the power, 2016-03-11 16:17:43]

Description was changed from

==========
Password update bubble UI improvement.

When current domain and domain of saved credentials don't coincide then show
update password bubbletitle as "Do you want to update password for <domain>?"
instead of "Do you want to save password for <domain>?".

BUG=593034
==========

to

==========
Password update bubble UI improvement.

When current domain and domain of saved credentials don't coincide then show
update password bubbletitle as "Do you want to update password for <domain>?"
instead of "Do you want to save password for <domain>?".

BUG=593034
==========

[commit-bot: I haz the power, 2016-03-11 16:17:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-11 16:20:04]

Description was changed from

==========
Password update bubble UI improvement.

When current domain and domain of saved credentials don't coincide then show
update password bubbletitle as "Do you want to update password for <domain>?"
instead of "Do you want to save password for <domain>?".

BUG=593034
==========

to

==========
Password update bubble UI improvement.

When current domain and domain of saved credentials don't coincide then show
update password bubbletitle as "Do you want to update password for <domain>?"
instead of "Do you want to save password for <domain>?".

BUG=593034

Committed: https://crrev.com/4a9874f00efac95d9b4b21ff17ef415c0b0d8f0a
Cr-Commit-Position: refs/heads/master@{#380646}
==========

[commit-bot: I haz the power, 2016-03-11 16:20:05]

Patchset 2 (id:??) landed as
https://crrev.com/4a9874f00efac95d9b4b21ff17ef415c0b0d8f0a
Cr-Commit-Position: refs/heads/master@{#380646}