Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc

Issue 1787653002: Password update bubble UI improvement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_view_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
index 15f082884fe1a392d92a85ff576293d315774537..4b0d891c84b2a57d921dbde3bb8aa04c17b6186a 100644
--- a/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
@@ -62,12 +62,18 @@ const struct {
{"https://another.org", "https://example.com:8001/login#form?value=3", true,
PasswordTittleType::SAVE_PASSWORD, "https://example.com:8001", 12, 29},
- // Update bubble.
+ // Update bubble, same domains.
{"http://example.com/landing", "http://example.com/login#form?value=3",
false, PasswordTittleType::UPDATE_PASSWORD, "this site", 0, 0},
{"http://example.com/landing", "http://example.com/login#form?value=3",
true, PasswordTittleType::UPDATE_PASSWORD, "this site", 12, 29},
+ // Update bubble, different domains.
+ {"https://another.org", "http://example.com/login#form?value=3", false,
+ PasswordTittleType::UPDATE_PASSWORD, "http://example.com", 0, 0},
+ {"https://another.org", "http://example.com/login#form?value=3", true,
+ PasswordTittleType::UPDATE_PASSWORD, "http://example.com", 12, 29},
+
// Same domains, federated credential.
{"http://example.com/landing", "http://example.com/login#form?value=3",
false, PasswordTittleType::SAVE_ACCOUNT, "this site", 0, 0},
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_view_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698