chrome/app/generated_resources.grd - Issue 1787653002: Password update bubble UI improvement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.

Issue 1787653002: Password update bubble UI improvement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index 3f4a837f325d39104c3d9bc95942c52fb160304b..ced4bbbbe3b2f40d6ab6f46b58fc0cb8c2ca8f1c 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -14335,6 +14335,9 @@ Please check your email at <ph name="ACCOUNT_EMAIL">$2<ex>jane.doe@gmail.com</ex

Do you want <ph name="PASSWORD_MANAGER_BRAND">$1<ex>Google Chrome</ex></ph> to save your password for <ph name="ORIGIN">$2<ex>example.com</ex></ph>?

</message>

+ <message name="IDS_UPDATE_PASSWORD_TITLE" desc="The title of the update password bubble when a password can be updated.">

vasilii 2016/03/11 13:27:29 I'd make both the name and the description mention

dvadym 2016/03/11 15:07:01 Done.

+ Do you want <ph name="PASSWORD_MANAGER_BRAND">$1<ex>Google Chrome</ex></ph> to update your password for <ph name="ORIGIN">$2<ex>example.com</ex></ph>?

+ </message>

Saved passwords for <ph name="ORIGIN">$1<ex>example.com</ex></ph>:

</message>

« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_view_utils.cc » ('j') | no next file with comments »