chrome/browser/ui/passwords/manage_passwords_view_utils.cc - Issue 1787653002: Password update bubble UI improvement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_view_utils.cc

Issue 1787653002: Password update bubble UI improvement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/passwords/manage_passwords_view_utils.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_view_utils.cc b/chrome/browser/ui/passwords/manage_passwords_view_utils.cc

index f70cc62c6eed98b698c4d7d2695da4e13f304e64..f584e39da7e42ea6d89ecd2833393df324f667d4 100644

--- a/chrome/browser/ui/passwords/manage_passwords_view_utils.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_view_utils.cc

@@ -98,7 +98,9 @@ void GetSavePasswordDialogTitleTextAndLinkRange(

// the one seen in the omnibox) and the password form post-submit navigation

// URL differs or not.

if (!SameDomainOrHost(user_visible_url, form_origin_url)) {

- title_id = IDS_SAVE_PASSWORD_TITLE;

+ title_id = dialog_type == PasswordTittleType::UPDATE_PASSWORD

+ ? IDS_UPDATE_PASSWORD_DIFFERENT_DOMAINS_TITLE

+ : IDS_SAVE_PASSWORD_DIFFERENT_DOMAINS_TITLE;

// TODO(palmer): Look into passing real language prefs here, not "".

// crbug.com/498069.

replacements.push_back(url_formatter::FormatUrlForSecurityDisplay(