Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 178673002: Rename Path to Path2D (Closed)

Created:
6 years, 10 months ago by jcgregorio
Modified:
6 years, 9 months ago
CC:
blink-reviews, arv+blink, dglazkov+blink, adamk+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive, zino
Base URL:
https://chromium.googlesource.com/chromium/blink.git@path
Visibility:
Public.

Description

Rename Path to Path2D This change affects Path and CanvasRenderingContext2D which has some methods which path Path arguments. Path, and after it's renamed Path2D, and the methods on CanvasRenderingContext2D that take Path/Path2D arguments are hidden behind the --enable-experimental-canvas-features flag and will remain hidden behind that flag. Agreement to rename Path to Path2D: http://lists.w3.org/Archives/Public/public-whatwg-archive/2013Nov/0204.html Spec reference: None, the spec will be updated to Path2D after the rename. Intent to Implement isn't needed: https://groups.google.com/a/chromium.org/d/msg/blink-dev/5l-nySXWkqA/62572JTekPcJ BUG=347128 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168842

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename DOMPath2D.h to Path2D.h, drop the ImplementedAs in the IDL. #

Patch Set 3 : Missed file rename in core.gypi. #

Patch Set 4 : Merge to head which includes isPoint and addPath changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -251 lines) Patch
M LayoutTests/fast/canvas/canvas-arc-negative-radius.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-arc-negative-radius-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-currentPath-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-path-addpath-expected.txt View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-path-object-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-currentPath.js View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-isPointInPath-winding.js View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-isPointInStroke-with-path.js View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-path-addpath.js View 1 2 3 5 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-path-constructors.js View 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-path-context-clip.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-path-context-fill.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-path-context-stroke.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-path-object.js View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 1 2 3 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 2 3 8 chunks +13 lines, -13 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 1 2 3 2 chunks +9 lines, -9 lines 0 comments Download
D Source/core/html/canvas/DOMPath.h View 1 2 3 1 chunk +0 lines, -90 lines 0 comments Download
D Source/core/html/canvas/Path.idl View 1 2 3 1 chunk +0 lines, -70 lines 0 comments Download
A + Source/core/html/canvas/Path2D.h View 1 2 3 3 chunks +14 lines, -14 lines 0 comments Download
A + Source/core/html/canvas/Path2D.idl View 1 2 3 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
jcgregorio
6 years, 10 months ago (2014-02-26 15:11:16 UTC) #1
Justin Novosad
https://codereview.chromium.org/178673002/diff/1/Source/core/html/canvas/Path2D.idl File Source/core/html/canvas/Path2D.idl (right): https://codereview.chromium.org/178673002/diff/1/Source/core/html/canvas/Path2D.idl#newcode34 Source/core/html/canvas/Path2D.idl:34: ImplementedAs=DOMPath2D Do we still need the "DOM" prefix? I ...
6 years, 10 months ago (2014-02-26 15:29:41 UTC) #2
jcgregorio
https://codereview.chromium.org/178673002/diff/1/Source/core/html/canvas/Path2D.idl File Source/core/html/canvas/Path2D.idl (right): https://codereview.chromium.org/178673002/diff/1/Source/core/html/canvas/Path2D.idl#newcode34 Source/core/html/canvas/Path2D.idl:34: ImplementedAs=DOMPath2D On 2014/02/26 15:29:42, junov wrote: > Do we ...
6 years, 10 months ago (2014-02-26 16:19:28 UTC) #3
Justin Novosad
lgtm
6 years, 10 months ago (2014-02-26 16:23:06 UTC) #4
dshwang
non-owner lgtm could you kick try bots?
6 years, 10 months ago (2014-02-26 16:45:05 UTC) #5
Rik
yes, this is a lgtm from me as well.
6 years, 10 months ago (2014-02-26 18:22:51 UTC) #6
Justin Novosad
FYI, this patch will interfere: https://codereview.chromium.org/170503002/
6 years, 9 months ago (2014-03-04 16:38:46 UTC) #7
jcgregorio
Yeah, let's wait for that to land and then I'll update this CL with all ...
6 years, 9 months ago (2014-03-04 16:40:50 UTC) #8
jcgregorio
Updated to include the isPoint and addPath changes. Kicked off new trybots. -joe On 2014/03/04 ...
6 years, 9 months ago (2014-03-07 17:59:58 UTC) #9
Justin Novosad
lgtm
6 years, 9 months ago (2014-03-10 13:56:44 UTC) #10
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 9 months ago (2014-03-10 14:28:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcgregorio@google.com/178673002/60001
6 years, 9 months ago (2014-03-10 14:31:28 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-10 15:30:15 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel
6 years, 9 months ago (2014-03-10 15:30:16 UTC) #14
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 9 months ago (2014-03-10 17:29:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcgregorio@google.com/178673002/60001
6 years, 9 months ago (2014-03-10 17:30:18 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 17:30:57 UTC) #17
Message was sent while issue was closed. 
Change committed as 168842

Powered by Google App Engine
This is Rietveld 408576698