Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1782543004: Reland: Mojo C++ bindings: replace '::' with '.' in the interface name. (Closed)

Created:
4 years, 9 months ago by yzshen1
Modified:
4 years, 9 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Mojo C++ bindings: replace '::' with '.' in the interface name. Previously the |foo::Bar::Name_| field was "foo::Bar". With this change it becomes "foo.Bar". Using C++-style namespace in the name doesn't makes too much sense because the name should remain the same across different languages. The original CL was https://codereview.chromium.org/1778793004/ BUG=None TBR=ben@chromium.org Committed: https://crrev.com/a061a917ebc0d16fb67d2644d93bfdca7eec92d3 Cr-Commit-Position: refs/heads/master@{#380459}

Patch Set 1 #

Patch Set 2 : fix mojo-helpers.html #

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782543004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782543004/20001
4 years, 9 months ago (2016-03-10 08:31:41 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/194499)
4 years, 9 months ago (2016-03-10 09:47:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782543004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782543004/20001
4 years, 9 months ago (2016-03-10 15:48:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/194609)
4 years, 9 months ago (2016-03-10 17:50:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782543004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782543004/20001
4 years, 9 months ago (2016-03-10 18:35:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-10 20:50:39 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a061a917ebc0d16fb67d2644d93bfdca7eec92d3 Cr-Commit-Position: refs/heads/master@{#380459}
4 years, 9 months ago (2016-03-10 20:52:28 UTC) #13
yzshen1
4 years, 9 months ago (2016-03-11 01:02:01 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1785803003/ by yzshen@chromium.org.

The reason for reverting is:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Test....

Powered by Google App Engine
This is Rietveld 408576698