mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl - Issue 1782543004: Reland: Mojo C++ bindings: replace '::' with '.' in the interface name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

Issue 1782543004: Reland: Mojo C++ bindings: replace '::' with '.' in the interface name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mojo-helpers.html Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/mojo/chrome_renderer_manifest.json ('k') | mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

index de7469c846da597aaf4f953b18b9f08e553ce4e7..15124540e91d83c65157a7dd96e6198b1cf58384 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

@@ -3,7 +3,6 @@

{%- set class_name = interface.name %}

{%- set proxy_name = interface.name ~ "Proxy" %}

-{%- set namespace_as_string = "%s"|format(namespace|replace(".","::")) %}

{%- macro alloc_params(struct, serialization_context) %}

bool success = true;

@@ -35,7 +34,7 @@ p_{{param.name}}

{%- endmacro %}

{#--- Begin #}

-MOJO_STATIC_CONST_MEMBER_DEFINITION const char {{class_name}}::Name_[] = "{{namespace_as_string}}::{{class_name}}";

+MOJO_STATIC_CONST_MEMBER_DEFINITION const char {{class_name}}::Name_[] = "{{namespace}}.{{class_name}}";

MOJO_STATIC_CONST_MEMBER_DEFINITION const uint32_t {{class_name}}::Version_;

{#--- Constants #}