Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1778793004: Mojo C++ bindings: replace '::' with '.' in the interface name. (Closed)

Created:
4 years, 9 months ago by yzshen1
Modified:
4 years, 9 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: replace '::' with '.' in the interface name. Previously the |foo::Bar::Name_| field was "foo::Bar". With this change it becomes "foo.Bar". Using C++-style namespace in the name doesn't makes too much sense because the name should remain the same across different languages. BUG=None Committed: https://crrev.com/026e10b3842af957773aee40dc3736eecb7faa0c Cr-Commit-Position: refs/heads/master@{#380301}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : update interface names in manifest.json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M content/browser/mojo/chrome_renderer_manifest.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/tests/connect/connect_unittests_manifest.json View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/shell/tests/shell/target_manifest.json View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
yzshen1
Hi, Ben. Please take a look. Thanks!
4 years, 9 months ago (2016-03-09 21:35:47 UTC) #2
Ben Goodger (Google)
lgtm
4 years, 9 months ago (2016-03-09 22:33:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778793004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778793004/20001
4 years, 9 months ago (2016-03-09 22:37:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778793004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778793004/40001
4 years, 9 months ago (2016-03-09 22:58:39 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-10 02:03:56 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/026e10b3842af957773aee40dc3736eecb7faa0c Cr-Commit-Position: refs/heads/master@{#380301}
4 years, 9 months ago (2016-03-10 02:06:30 UTC) #11
Dirk Pranke
4 years, 9 months ago (2016-03-10 03:59:24 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1771353009/ by dpranke@chromium.org.

The reason for reverting is: I think this broke the
harness-tests/mojo-helpers.html layout test:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpe...
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/6....

Powered by Google App Engine
This is Rietveld 408576698