Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1785803003: Revert of Reland: Mojo C++ bindings: replace '::' with '.' in the interface name. (Closed)

Created:
4 years, 9 months ago by yzshen1
Modified:
4 years, 9 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Mojo C++ bindings: replace '::' with '.' in the interface name. (patchset #2 id:20001 of https://codereview.chromium.org/1782543004/ ) Reason for revert: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/33342 Original issue's description: > Reland: Mojo C++ bindings: replace '::' with '.' in the interface name. > > Previously the |foo::Bar::Name_| field was "foo::Bar". With this change it > becomes "foo.Bar". > > Using C++-style namespace in the name doesn't makes too much sense because the > name should remain the same across different languages. > > The original CL was https://codereview.chromium.org/1778793004/ > > BUG=None > TBR=ben@chromium.org > > Committed: https://crrev.com/a061a917ebc0d16fb67d2644d93bfdca7eec92d3 > Cr-Commit-Position: refs/heads/master@{#380459} TBR=ben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/080cd66aa15c526bdb5b8363e21599598f5c0303 Cr-Commit-Position: refs/heads/master@{#380503}

Patch Set 1 #

Messages

Total messages: 5 (1 generated)
yzshen1
Created Revert of Reland: Mojo C++ bindings: replace '::' with '.' in the interface name.
4 years, 9 months ago (2016-03-11 01:02:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785803003/1
4 years, 9 months ago (2016-03-11 01:02:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 01:03:22 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 01:05:04 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/080cd66aa15c526bdb5b8363e21599598f5c0303
Cr-Commit-Position: refs/heads/master@{#380503}

Powered by Google App Engine
This is Rietveld 408576698