CC Animation: Erase old animation system.

CC Animation: Erase old animation system.

Basically, specialize all the code as if:
- use_compositor_animation_timelines is always true.
- Layer::layer_animation_controller_ is always nullptr.
- LayerImpl::layer_animation_controller_ is always nullptr.
- LayerTreeHost::animation_registrar_ is always nullptr.
- LayerTreeHostImpl::animation_registrar_ is always nullptr.

Next CL: Erase cc::LayerSettings everywhere.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/9556c73c3d89db2226920a295e3a579dc6a1eaa3
Cr-Commit-Position: refs/heads/master@{#380576}

[loyso (OOO), 2016-03-09 04:35:24]

Description was changed from

==========
CC Animation: Erase old animation system.

BUG=575041
==========

to

==========
CC Animation: Erase old animation system.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-03-09 04:35:54]

Description was changed from

==========
CC Animation: Erase old animation system.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Erase old animation system.

Depends on https://codereview.chromium.org/1777773002/

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-03-09 04:36:13]

loyso@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org

[loyso (OOO), 2016-03-09 04:52:57]

Description was changed from

==========
CC Animation: Erase old animation system.

Depends on https://codereview.chromium.org/1777773002/

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Erase old animation system.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-03-09 05:04:56]

Description was changed from

==========
CC Animation: Erase old animation system.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Erase old animation system.

Next CL: Erase cc::LayerSettings everywhere.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-03-09 05:17:54]

Description was changed from

==========
CC Animation: Erase old animation system.

Next CL: Erase cc::LayerSettings everywhere.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Erase old animation system.

Basically, specialize all the code as if:
- use_compositor_animation_timelines is always true.
- Layer::layer_animation_controller_ is always nullptr.
- LayerImpl::layer_animation_controller_ is always nullptr.
- LayerTreeHost::animation_registrar_ is always nullptr.
- LayerTreeHostImpl::animation_registrar_ is always nullptr.

Next CL: Erase cc::LayerSettings everywhere.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-03-09 06:08:57]

https://codereview.chromium.org/1782433002/diff/20001/cc/trees/layer_tree_imp...
File cc/trees/layer_tree_impl.cc (left):

https://codereview.chromium.org/1782433002/diff/20001/cc/trees/layer_tree_imp...
cc/trees/layer_tree_impl.cc:1868: void
LayerTreeImpl::InputScrollAnimationFinished() {
This one is non obvious:
Erased in favor for LayerTreeHostImpl::ScrollOffsetAnimationFinished (that's a
copy-paste).
See cc::AnimationHost::ScrollOffsetAnimations::NotifyAnimationFinished and
MutatorHostClient::ScrollOffsetAnimationFinished if interested.

[loyso (OOO), 2016-03-09 06:11:04]

https://codereview.chromium.org/1782433002/diff/40001/cc/layers/layer.h
File cc/layers/layer.h (left):

https://codereview.chromium.org/1782433002/diff/40001/cc/layers/layer.h#oldco...
cc/layers/layer.h:433: bool HasActiveAnimation() const;
My todo: Rename it to HasActiveAnimationForTesting.

[loyso (OOO), 2016-03-09 06:17:03]

https://codereview.chromium.org/1782433002/diff/40001/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (left):

https://codereview.chromium.org/1782433002/diff/40001/cc/layers/layer_impl.cc...
cc/layers/layer_impl.cc:1703: void
LayerImpl::NotifyAnimationFinished(base::TimeTicks monotonic_time,
Once again:
This one is non obvious:
Erased in favor for LayerTreeHostImpl::ScrollOffsetAnimationFinished (that's a
copy-paste).
See cc::AnimationHost::ScrollOffsetAnimations::NotifyAnimationFinished and
MutatorHostClient::ScrollOffsetAnimationFinished if interested.

[loyso (OOO), 2016-03-09 06:17:54]

https://codereview.chromium.org/1782433002/diff/40001/cc/trees/layer_tree_imp...
File cc/trees/layer_tree_impl.cc (left):

https://codereview.chromium.org/1782433002/diff/40001/cc/trees/layer_tree_imp...
cc/trees/layer_tree_impl.cc:1868: void
LayerTreeImpl::InputScrollAnimationFinished() {
Erased in favor for LayerTreeHostImpl::ScrollOffsetAnimationFinished (that's a
copy-paste).

[ajuma, 2016-03-09 14:25:04]

lgtm!!

https://codereview.chromium.org/1782433002/diff/40001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/1782433002/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:5455:
AddOpacityTransitionToLayerWithPlayer(child_->id(), timeline(), 10.0, 0.9f,
Weird indentation here (running "git cl format" should fix this).

[Ian Vollick, 2016-03-09 14:41:11]

On 2016/03/09 14:25:04, ajuma wrote:
> lgtm!!
> 
>
https://codereview.chromium.org/1782433002/diff/40001/cc/trees/layer_tree_hos...
> File cc/trees/layer_tree_host_common_unittest.cc (right):
> 
>
https://codereview.chromium.org/1782433002/diff/40001/cc/trees/layer_tree_hos...
> cc/trees/layer_tree_host_common_unittest.cc:5455:
> AddOpacityTransitionToLayerWithPlayer(child_->id(), timeline(), 10.0, 0.9f,
> Weird indentation here (running "git cl format" should fix this).

nice! lgtm, too.

[loyso (OOO), 2016-03-09 23:04:22]

https://codereview.chromium.org/1782433002/diff/40001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/1782433002/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:5455:
AddOpacityTransitionToLayerWithPlayer(child_->id(), timeline(), 10.0, 0.9f,
On 2016/03/09 14:25:04, ajuma wrote:
> Weird indentation here (running "git cl format" should fix this).

Surprisingly, git cl format doesn't fix it (which was a major problem for this
CL).
Since I didn't touch that line, an incremental |git cl format| leaves it
untouched.

Done (manually).

[danakj, 2016-03-09 23:05:58]

https://codereview.chromium.org/1782433002/diff/40001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/1782433002/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:5455:
AddOpacityTransitionToLayerWithPlayer(child_->id(), timeline(), 10.0, 0.9f,
On 2016/03/09 23:04:21, loyso wrote:
> On 2016/03/09 14:25:04, ajuma wrote:
> > Weird indentation here (running "git cl format" should fix this).
> 
> Surprisingly, git cl format doesn't fix it (which was a major problem for this
> CL).
> Since I didn't touch that line, an incremental |git cl format| leaves it
> untouched.
> 
> Done (manually). 

Can you file a bug about this to infra and cc djasper and thakis?

[loyso (OOO), 2016-03-09 23:44:32]

On 2016/03/09 23:05:58, danakj wrote:
> > > Weird indentation here (running "git cl format" should fix this).
> > Surprisingly, git cl format doesn't fix it (which was a major problem for
this
> > CL).
> > Since I didn't touch that line, an incremental |git cl format| leaves it
> > untouched.
> Can you file a bug about this to infra and cc djasper and thakis?
Done. https://bugs.chromium.org/p/chromium/issues/detail?id=593519

[loyso (OOO), 2016-03-10 05:16:45]

Credits to:
dstockwell@, vollick@, ajuma@, piman@. This patch wouldn't be possible without
you, guys!
Thank you so much.

[loyso (OOO), 2016-03-10 05:56:25]

The CQ bit was checked by loyso@chromium.org

[loyso (OOO), 2016-03-10 05:56:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
vollick@chromium.org, ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1782433002/#ps60001
(title: "Remove vtbl in LayerAnimationController. Fix formatting.")

[commit-bot: I haz the power, 2016-03-10 05:56:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782433002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782433002/60001

[commit-bot: I haz the power, 2016-03-10 07:07:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 07:07:14]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[loyso (OOO), 2016-03-10 23:55:19]

The CQ bit was checked by loyso@chromium.org

[commit-bot: I haz the power, 2016-03-10 23:56:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782433002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782433002/60001

[commit-bot: I haz the power, 2016-03-11 00:38:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 00:38:42]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[loyso (OOO), 2016-03-11 05:11:34]

The CQ bit was checked by loyso@chromium.org

[commit-bot: I haz the power, 2016-03-11 05:12:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782433002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782433002/60001

[commit-bot: I haz the power, 2016-03-11 07:55:06]

Description was changed from

==========
CC Animation: Erase old animation system.

Basically, specialize all the code as if:
- use_compositor_animation_timelines is always true.
- Layer::layer_animation_controller_ is always nullptr.
- LayerImpl::layer_animation_controller_ is always nullptr.
- LayerTreeHost::animation_registrar_ is always nullptr.
- LayerTreeHostImpl::animation_registrar_ is always nullptr.

Next CL: Erase cc::LayerSettings everywhere.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Erase old animation system.

Basically, specialize all the code as if:
- use_compositor_animation_timelines is always true.
- Layer::layer_animation_controller_ is always nullptr.
- LayerImpl::layer_animation_controller_ is always nullptr.
- LayerTreeHost::animation_registrar_ is always nullptr.
- LayerTreeHostImpl::animation_registrar_ is always nullptr.

Next CL: Erase cc::LayerSettings everywhere.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-03-11 07:55:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-11 07:56:41]

Description was changed from

==========
CC Animation: Erase old animation system.

Basically, specialize all the code as if:
- use_compositor_animation_timelines is always true.
- Layer::layer_animation_controller_ is always nullptr.
- LayerImpl::layer_animation_controller_ is always nullptr.
- LayerTreeHost::animation_registrar_ is always nullptr.
- LayerTreeHostImpl::animation_registrar_ is always nullptr.

Next CL: Erase cc::LayerSettings everywhere.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Erase old animation system.

Basically, specialize all the code as if:
- use_compositor_animation_timelines is always true.
- Layer::layer_animation_controller_ is always nullptr.
- LayerImpl::layer_animation_controller_ is always nullptr.
- LayerTreeHost::animation_registrar_ is always nullptr.
- LayerTreeHostImpl::animation_registrar_ is always nullptr.

Next CL: Erase cc::LayerSettings everywhere.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/9556c73c3d89db2226920a295e3a579dc6a1eaa3
Cr-Commit-Position: refs/heads/master@{#380576}
==========

[commit-bot: I haz the power, 2016-03-11 07:56:42]

Patchset 4 (id:??) landed as
https://crrev.com/9556c73c3d89db2226920a295e3a579dc6a1eaa3
Cr-Commit-Position: refs/heads/master@{#380576}