Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1747783002: CC Animation: Erase old animation system in Android Compositor. (Closed)

Created:
4 years, 9 months ago by loyso (OOO)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su, esprehn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Erase old animation system in Android Compositor. Basically, specialize all the code as if use_compositor_animation_timelines is always true. Next CL: Erase cc::LayerSettings everywhere. BUG=575041 Committed: https://crrev.com/e7c252c14c9afe6ef128f2c0c7bd75e4a1c14e73 Cr-Commit-Position: refs/heads/master@{#380587}

Patch Set 1 #

Patch Set 2 : Fix compilation. #

Patch Set 3 : Fix compilation. #

Patch Set 4 : Fix compilation. #

Patch Set 5 : Fix compilation. #

Total comments: 1

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -127 lines) Patch
M chrome/browser/android/DEPS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/compositor/compositor_view.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/decoration_title.cc View 1 2 3 4 5 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/android/compositor/layer/content_layer.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/layer/contextual_search_layer.cc View 1 2 3 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/android/compositor/layer/crushed_sprite_layer.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/layer/overlay_panel_layer.cc View 1 2 3 2 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/android/compositor/layer/tab_handle_layer.cc View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/android/compositor/layer/tab_layer.cc View 1 2 3 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/android/compositor/layer/thumbnail_layer.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/layer/toolbar_layer.cc View 1 2 3 4 2 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/android/compositor/scene_layer/scene_layer.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/scene_layer/tab_strip_scene_layer.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/android/composited_touch_handle_drawable.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/android/content_startup_flags.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 3 4 5 4 chunks +2 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/public/browser/android/compositor.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M ui/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/android/edge_effect.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/android/edge_effect_l.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/android/overscroll_glow.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ui/android/ui_android.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/android/window_android_compositor.h View 1 2 3 4 5 2 chunks +0 lines, -4 lines 0 comments Download
D ui/android/window_android_compositor.cc View 1 chunk +0 lines, -28 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 45 (18 generated)
loyso (OOO)
4 years, 9 months ago (2016-02-29 02:31:36 UTC) #1
loyso (OOO)
https://codereview.chromium.org/1747783002/diff/80001/chrome/browser/android/DEPS File chrome/browser/android/DEPS (right): https://codereview.chromium.org/1747783002/diff/80001/chrome/browser/android/DEPS#newcode10 chrome/browser/android/DEPS:10: "+cc/layers/layer_settings.h", This is temp and will be deleted in ...
4 years, 9 months ago (2016-02-29 06:14:37 UTC) #7
kinuko
content/ changes lgtm
4 years, 9 months ago (2016-02-29 09:02:38 UTC) #8
loyso (OOO)
ui/android, chrome/browser/android review needed! PTAL, this is a trivial deletion.
4 years, 9 months ago (2016-03-01 01:40:18 UTC) #10
Bernhard Bauer
RSLGTM
4 years, 9 months ago (2016-03-01 10:33:15 UTC) #11
Bernhard Bauer
On 2016/03/01 10:33:15, Bernhard Bauer wrote: > RSLGTM (Which Rietveld doesn't recognize, I guess? Rubberstamp ...
4 years, 9 months ago (2016-03-01 10:33:49 UTC) #12
newt (away)
sievers: Could you take a look at ui/android? Looks like you moved these files into ...
4 years, 9 months ago (2016-03-02 02:23:42 UTC) #14
loyso (OOO)
PTAL, anyone!
4 years, 9 months ago (2016-03-03 02:22:57 UTC) #15
loyso (OOO)
Friendly ping! This is trivial deletion which blocks ongoing migration.
4 years, 9 months ago (2016-03-03 23:01:35 UTC) #17
no sievers
On 2016/03/02 02:23:42, newt wrote: > sievers: Could you take a look at ui/android? Looks ...
4 years, 9 months ago (2016-03-07 19:16:52 UTC) #18
loyso (OOO)
On 2016/03/07 19:16:52, sievers wrote: > On 2016/03/02 02:23:42, newt wrote: > > sievers: Could ...
4 years, 9 months ago (2016-03-07 23:55:37 UTC) #19
David Trainor- moved to gerrit
ui/android lgtm
4 years, 9 months ago (2016-03-08 18:55:11 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747783002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747783002/80001
4 years, 9 months ago (2016-03-08 22:42:31 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/154590)
4 years, 9 months ago (2016-03-08 22:55:36 UTC) #24
loyso (OOO)
** Presubmit ERRORS ** Missing LGTM from OWNERS of dependencies added to DEPS: '+cc/layers/layer_settings.h', Hmm. ...
4 years, 9 months ago (2016-03-08 22:59:32 UTC) #25
loyso (OOO)
On 2016/03/08 22:59:32, loyso wrote: > Missing LGTM from OWNERS of dependencies added to DEPS: ...
4 years, 9 months ago (2016-03-08 23:02:14 UTC) #26
David Trainor- moved to gerrit
chrome/browser/android/deps lgtm
4 years, 9 months ago (2016-03-10 00:05:31 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747783002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747783002/80001
4 years, 9 months ago (2016-03-10 00:08:38 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/155125)
4 years, 9 months ago (2016-03-10 00:19:30 UTC) #31
loyso (OOO)
Still ** Presubmit ERRORS ** Missing LGTM from OWNERS of dependencies added to DEPS: '+cc/layers/layer_settings.h',
4 years, 9 months ago (2016-03-10 00:28:40 UTC) #32
loyso (OOO)
Filed a bug for Infra: https://bugs.chromium.org/p/chromium/issues/detail?id=593533
4 years, 9 months ago (2016-03-10 00:34:35 UTC) #33
loyso (OOO)
On 2016/03/10 00:05:31, David Trainor wrote: > chrome/browser/android/deps lgtm chrome/browser/android/DEPS maybe? :)
4 years, 9 months ago (2016-03-10 00:35:37 UTC) #34
Ian Vollick
On 2016/03/10 00:35:37, loyso wrote: > On 2016/03/10 00:05:31, David Trainor wrote: > > chrome/browser/android/deps ...
4 years, 9 months ago (2016-03-11 02:34:01 UTC) #35
commit-bot: I haz the power
This CL has an open dependency (Issue 1782433002 Patch 60001). Please resolve the dependency and ...
4 years, 9 months ago (2016-03-11 02:51:55 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747783002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747783002/100001
4 years, 9 months ago (2016-03-11 08:08:33 UTC) #41
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 9 months ago (2016-03-11 09:40:37 UTC) #43
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 09:42:07 UTC) #45
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/e7c252c14c9afe6ef128f2c0c7bd75e4a1c14e73
Cr-Commit-Position: refs/heads/master@{#380587}

Powered by Google App Engine
This is Rietveld 408576698