Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1470)

Unified Diff: cc/layers/layer_impl.h

Issue 1782433002: CC Animation: Erase old animation system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@erasetests
Patch Set: Remove vtbl in LayerAnimationController. Fix formatting. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/layer.cc ('k') | cc/layers/layer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/layer_impl.h
diff --git a/cc/layers/layer_impl.h b/cc/layers/layer_impl.h
index a7cfc8749b8f76919a828c076528c883caad76d1..f1adfd5a1912bb64276d9a10293c97bd82c42839 100644
--- a/cc/layers/layer_impl.h
+++ b/cc/layers/layer_impl.h
@@ -17,10 +17,7 @@
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "base/values.h"
-#include "cc/animation/animation_delegate.h"
-#include "cc/animation/layer_animation_controller.h"
-#include "cc/animation/layer_animation_value_observer.h"
-#include "cc/animation/layer_animation_value_provider.h"
+#include "cc/animation/target_property.h"
#include "cc/base/cc_export.h"
#include "cc/base/region.h"
#include "cc/base/synced_property.h"
@@ -79,9 +76,7 @@ enum DrawMode {
DRAW_MODE_RESOURCELESS_SOFTWARE
};
-class CC_EXPORT LayerImpl : public LayerAnimationValueObserver,
- public LayerAnimationValueProvider,
- public AnimationDelegate {
+class CC_EXPORT LayerImpl {
public:
typedef LayerImplList RenderSurfaceListType;
typedef LayerImplList LayerListType;
@@ -93,36 +88,18 @@ class CC_EXPORT LayerImpl : public LayerAnimationValueObserver,
return make_scoped_ptr(new LayerImpl(tree_impl, id));
}
- ~LayerImpl() override;
+ virtual ~LayerImpl();
int id() const { return layer_id_; }
- // LayerAnimationValueProvider implementation.
- gfx::ScrollOffset ScrollOffsetForAnimation() const override;
-
- // LayerAnimationValueObserver implementation.
- void OnFilterAnimated(const FilterOperations& filters) override;
- void OnOpacityAnimated(float opacity) override;
- void OnTransformAnimated(const gfx::Transform& transform) override;
- void OnScrollOffsetAnimated(const gfx::ScrollOffset& scroll_offset) override;
- void OnAnimationWaitingForDeletion() override;
- void OnTransformIsPotentiallyAnimatingChanged(bool is_animating) override;
- bool IsActive() const override;
-
- // AnimationDelegate implementation.
- void NotifyAnimationStarted(base::TimeTicks monotonic_time,
- TargetProperty::Type target_property,
- int group) override{};
- void NotifyAnimationFinished(base::TimeTicks monotonic_time,
- TargetProperty::Type target_property,
- int group) override;
- void NotifyAnimationAborted(base::TimeTicks monotonic_time,
- TargetProperty::Type target_property,
- int group) override{};
- void NotifyAnimationTakeover(base::TimeTicks monotonic_time,
- TargetProperty::Type target_property,
- double animation_start_time,
- scoped_ptr<AnimationCurve> curve) override {}
+ // Interactions with attached animations.
+ gfx::ScrollOffset ScrollOffsetForAnimation() const;
+ void OnFilterAnimated(const FilterOperations& filters);
+ void OnOpacityAnimated(float opacity);
+ void OnTransformAnimated(const gfx::Transform& transform);
+ void OnScrollOffsetAnimated(const gfx::ScrollOffset& scroll_offset);
+ void OnTransformIsPotentiallyAnimatingChanged(bool is_animating);
+ bool IsActive() const;
// Tree structure.
LayerImpl* parent() { return parent_; }
@@ -558,14 +535,6 @@ class CC_EXPORT LayerImpl : public LayerAnimationValueObserver,
void ResetAllChangeTrackingForSubtree();
- LayerAnimationController* layer_animation_controller() {
- return layer_animation_controller_.get();
- }
-
- const LayerAnimationController* layer_animation_controller() const {
- return layer_animation_controller_.get();
- }
-
virtual SimpleEnclosedRegion VisibleOpaqueRegion() const;
virtual void DidBecomeActive() {}
@@ -815,9 +784,6 @@ class CC_EXPORT LayerImpl : public LayerAnimationValueObserver,
// space.
gfx::Rect damage_rect_;
- // Manages animations for this layer.
- scoped_refptr<LayerAnimationController> layer_animation_controller_;
-
std::vector<scoped_ptr<CopyOutputRequest>> copy_requests_;
// Group of properties that need to be computed based on the layer tree
« no previous file with comments | « cc/layers/layer.cc ('k') | cc/layers/layer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698