Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 1766483002: CC Animation: Erase old animation tests. (Closed)

Created:
4 years, 9 months ago by loyso (OOO)
Modified:
4 years, 9 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Erase old animation tests. Merge tests from layer_tree_host_unittest_animation_timelines.cc onto their respective layer_tree_host_unittest_animation.cc entries. Erase layer_tree_host_unittest_animation_timelines.cc. BUG=575041 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/b6c2479b02acfb7ad67e5f6db0b94aa8d17e09d0 Cr-Commit-Position: refs/heads/master@{#380343}

Patch Set 1 #

Patch Set 2 : Update and sync old and new tests. #

Patch Set 3 : Sync again. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -1533 lines) Patch
M cc/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M cc/cc_tests.gyp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 2 3 37 chunks +377 lines, -78 lines 0 comments Download
D cc/trees/layer_tree_host_unittest_animation_timelines.cc View 1 2 3 1 chunk +0 lines, -1453 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
loyso (OOO)
4 years, 9 months ago (2016-03-03 23:49:34 UTC) #4
ajuma
lgtm
4 years, 9 months ago (2016-03-04 00:10:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766483002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766483002/60001
4 years, 9 months ago (2016-03-10 00:17:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/186775)
4 years, 9 months ago (2016-03-10 01:02:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766483002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766483002/60001
4 years, 9 months ago (2016-03-10 01:26:12 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/186905)
4 years, 9 months ago (2016-03-10 03:05:25 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766483002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766483002/60001
4 years, 9 months ago (2016-03-10 05:02:59 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-10 05:42:36 UTC) #20
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 05:43:28 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b6c2479b02acfb7ad67e5f6db0b94aa8d17e09d0
Cr-Commit-Position: refs/heads/master@{#380343}

Powered by Google App Engine
This is Rietveld 408576698