Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1780523005: Fix JSON serialization of PerformanceEntry subclasses (Closed)

Created:
4 years, 9 months ago by Kunihiko Sakamoto
Modified:
4 years, 9 months ago
Reviewers:
kinuko
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix JSON serialization of PerformanceEntry subclasses Attributes defined in PerformanceEntry subclasses were not included in serialized object because toJSONForBinding() wasn't polymorphic. BUG=592171 test=http/tests/misc/performance-entry-serializer.html Committed: https://crrev.com/48db6a49b37d8302a9bedd6321110546dccaf7eb Cr-Commit-Position: refs/heads/master@{#380577}

Patch Set 1 #

Messages

Total messages: 11 (6 generated)
Kunihiko Sakamoto
PTAL
4 years, 9 months ago (2016-03-10 09:22:36 UTC) #4
kinuko
lgtm
4 years, 9 months ago (2016-03-10 14:20:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780523005/1
4 years, 9 months ago (2016-03-11 00:58:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 08:11:15 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 08:12:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48db6a49b37d8302a9bedd6321110546dccaf7eb
Cr-Commit-Position: refs/heads/master@{#380577}

Powered by Google App Engine
This is Rietveld 408576698