third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h - Issue 1780523005: Fix JSON serialization of PerformanceEntry subclasses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h

Issue 1780523005: Fix JSON serialization of PerformanceEntry subclasses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/timing/PerformanceRenderTiming.cpp ('k') | third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h

diff --git a/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h b/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h

index 0ec1909d4344de894f59e1b3ef540fa74f139bc3..98858fe43ca52e2faa08ac94f3dd8b5e45565803 100644

--- a/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h

+++ b/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h

@@ -69,6 +69,9 @@ public:

double responseStart() const;

double responseEnd() const;

+protected:

+ void buildJSONValue(V8ObjectBuilder&) const override;

private:

PerformanceResourceTiming(const ResourceTimingInfo&, double timeOrigin, double startTime, double lastRedirectEndTime, bool m_allowTimingDetails, bool m_allowRedirectDetails);

~PerformanceResourceTiming() override;