third_party/WebKit/Source/core/timing/PerformanceCompositeTiming.h - Issue 1780523005: Fix JSON serialization of PerformanceEntry subclasses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceCompositeTiming.h

Issue 1780523005: Fix JSON serialization of PerformanceEntry subclasses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/misc/performance-entry-serializer.html ('k') | third_party/WebKit/Source/core/timing/PerformanceCompositeTiming.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/timing/PerformanceCompositeTiming.h

diff --git a/third_party/WebKit/Source/core/timing/PerformanceCompositeTiming.h b/third_party/WebKit/Source/core/timing/PerformanceCompositeTiming.h

index e2466a537540c344e4f30221e94be45b7e620567..908cb30b9f92f267d3dcadfa9108fa6f46fb43a7 100644

--- a/third_party/WebKit/Source/core/timing/PerformanceCompositeTiming.h

+++ b/third_party/WebKit/Source/core/timing/PerformanceCompositeTiming.h

@@ -53,6 +53,9 @@ public:

DECLARE_VIRTUAL_TRACE();

+protected:

+ void buildJSONValue(V8ObjectBuilder&) const override;

private:

PerformanceCompositeTiming(Document* requestingDocument, unsigned sourceFrame, double startTime);

~PerformanceCompositeTiming() override;