third_party/WebKit/Source/core/timing/PerformanceEntry.cpp - Issue 1780523005: Fix JSON serialization of PerformanceEntry subclasses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceEntry.cpp

Issue 1780523005: Fix JSON serialization of PerformanceEntry subclasses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/timing/PerformanceEntry.h ('k') | third_party/WebKit/Source/core/timing/PerformanceRenderTiming.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/timing/PerformanceEntry.cpp

diff --git a/third_party/WebKit/Source/core/timing/PerformanceEntry.cpp b/third_party/WebKit/Source/core/timing/PerformanceEntry.cpp

index 52a6387df9dfdee5d6b74d78f562ac80573762a1..0812ee53e77f501ca58c8fcd632e8e8cb9da36aa 100644

--- a/third_party/WebKit/Source/core/timing/PerformanceEntry.cpp

+++ b/third_party/WebKit/Source/core/timing/PerformanceEntry.cpp

@@ -86,11 +86,16 @@ PerformanceEntry::EntryType PerformanceEntry::toEntryTypeEnum(const String& entr

ScriptValue PerformanceEntry::toJSONForBinding(ScriptState* scriptState) const

{

V8ObjectBuilder result(scriptState);

- result.addString("name", name());

- result.addString("entryType", entryType());

- result.addNumber("startTime", startTime());

- result.addNumber("duration", duration());

+ buildJSONValue(result);

return result.scriptValue();

}

+void PerformanceEntry::buildJSONValue(V8ObjectBuilder& builder) const

+ builder.addString("name", name());

+ builder.addString("entryType", entryType());

+ builder.addNumber("startTime", startTime());

+ builder.addNumber("duration", duration());

} // namespace blink