Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Side by Side Diff: third_party/WebKit/Source/core/timing/PerformanceEntry.h

Issue 1780523005: Fix JSON serialization of PerformanceEntry subclasses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 23 matching lines...) Expand all
34 34
35 #include "bindings/core/v8/ScriptWrappable.h" 35 #include "bindings/core/v8/ScriptWrappable.h"
36 #include "core/CoreExport.h" 36 #include "core/CoreExport.h"
37 #include "platform/heap/Handle.h" 37 #include "platform/heap/Handle.h"
38 #include "wtf/text/WTFString.h" 38 #include "wtf/text/WTFString.h"
39 39
40 namespace blink { 40 namespace blink {
41 41
42 class ScriptState; 42 class ScriptState;
43 class ScriptValue; 43 class ScriptValue;
44 class V8ObjectBuilder;
44 45
45 using PerformanceEntryType = unsigned char; 46 using PerformanceEntryType = unsigned char;
46 using PerformanceEntryTypeMask = unsigned char; 47 using PerformanceEntryTypeMask = unsigned char;
47 48
48 class CORE_EXPORT PerformanceEntry : public GarbageCollectedFinalized<Performanc eEntry>, public ScriptWrappable { 49 class CORE_EXPORT PerformanceEntry : public GarbageCollectedFinalized<Performanc eEntry>, public ScriptWrappable {
49 DEFINE_WRAPPERTYPEINFO(); 50 DEFINE_WRAPPERTYPEINFO();
50 public: 51 public:
51 virtual ~PerformanceEntry(); 52 virtual ~PerformanceEntry();
52 53
53 enum EntryType { 54 enum EntryType {
(...skipping 24 matching lines...) Expand all
78 { 79 {
79 return a->startTime() < b->startTime(); 80 return a->startTime() < b->startTime();
80 } 81 }
81 82
82 static EntryType toEntryTypeEnum(const String& entryType); 83 static EntryType toEntryTypeEnum(const String& entryType);
83 84
84 DEFINE_INLINE_VIRTUAL_TRACE() { } 85 DEFINE_INLINE_VIRTUAL_TRACE() { }
85 86
86 protected: 87 protected:
87 PerformanceEntry(const String& name, const String& entryType, double startTi me, double finishTime); 88 PerformanceEntry(const String& name, const String& entryType, double startTi me, double finishTime);
89 virtual void buildJSONValue(V8ObjectBuilder&) const;
88 90
89 private: 91 private:
90 const String m_name; 92 const String m_name;
91 const String m_entryType; 93 const String m_entryType;
92 const double m_startTime; 94 const double m_startTime;
93 const double m_duration; 95 const double m_duration;
94 const PerformanceEntryType m_entryTypeEnum; 96 const PerformanceEntryType m_entryTypeEnum;
95 }; 97 };
96 98
97 } // namespace blink 99 } // namespace blink
98 100
99 #endif // PerformanceEntry_h 101 #endif // PerformanceEntry_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698