Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1772463002: use Make instead of Create to return a shared shader (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

use Make instead of Create to return a shared shader Partially updated call sites. Undefine the flag in SkSHader.h to convert the remaining sites. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1772463002 Committed: https://skia.googlesource.com/skia/+/8a21c9fe7f5fef9e87115defef27bd7218419f28

Patch Set 1 #

Patch Set 2 : partial update of skia call-sites #

Total comments: 25

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+519 lines, -549 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.h View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 1 2 3 4 chunks +30 lines, -25 lines 0 comments Download
M gm/alphagradients.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M gm/arithmode.cpp View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M gm/badpaint.cpp View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M gm/bitmapshader.cpp View 1 2 3 chunks +4 lines, -9 lines 0 comments Download
M gm/gm.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M gm/lcdblendmodes.cpp View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M gm/pixelsnap.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkShader.h View 1 2 3 4 chunks +26 lines, -13 lines 0 comments Download
M include/effects/SkGradientShader.h View 4 chunks +82 lines, -32 lines 0 comments Download
M samplecode/PerlinPatch.cpp View 1 4 chunks +6 lines, -11 lines 0 comments Download
M samplecode/Sample2PtRadial.cpp View 1 1 chunk +3 lines, -5 lines 0 comments Download
M samplecode/SampleAARectModes.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M samplecode/SampleAARects.cpp View 1 1 chunk +2 lines, -4 lines 0 comments Download
M samplecode/SampleAll.cpp View 1 7 chunks +12 lines, -16 lines 0 comments Download
M samplecode/SampleBigGradient.cpp View 1 3 chunks +6 lines, -8 lines 0 comments Download
M samplecode/SampleBitmapRect.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/SampleCamera.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/SampleColorFilter.cpp View 1 2 chunks +1 line, -5 lines 0 comments Download
M samplecode/SampleDegenerateTwoPtRadials.cpp View 1 1 chunk +3 lines, -5 lines 0 comments Download
M samplecode/SampleDither.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M samplecode/SampleDitherBitmap.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M samplecode/SampleEffects.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/SampleFatBits.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M samplecode/SampleGradients.cpp View 1 6 chunks +20 lines, -23 lines 0 comments Download
M samplecode/SampleHairModes.cpp View 1 2 chunks +4 lines, -6 lines 0 comments Download
M samplecode/SampleLayers.cpp View 1 2 chunks +3 lines, -5 lines 0 comments Download
M samplecode/SamplePatch.cpp View 1 3 chunks +7 lines, -12 lines 0 comments Download
M samplecode/SampleQuadStroker.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M samplecode/SampleRegion.cpp View 1 3 chunks +4 lines, -6 lines 0 comments Download
M samplecode/SampleRepeatTile.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M samplecode/SampleShaderText.cpp View 1 4 chunks +17 lines, -17 lines 0 comments Download
M samplecode/SampleShaders.cpp View 1 2 5 chunks +13 lines, -25 lines 0 comments Download
M samplecode/SampleSlides.cpp View 1 4 chunks +16 lines, -22 lines 0 comments Download
M samplecode/SampleTiling.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M samplecode/SampleTinyBitmap.cpp View 1 3 chunks +5 lines, -7 lines 0 comments Download
M samplecode/SampleVertices.cpp View 1 3 chunks +6 lines, -12 lines 0 comments Download
M samplecode/SampleXfer.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M samplecode/SampleXfermodesBlur.cpp View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/animator/SkDrawGradient.cpp View 1 2 chunks +8 lines, -12 lines 0 comments Download
M src/animator/SkDrawShader.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/c/sk_surface.cpp View 4 chunks +18 lines, -24 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 2 1 chunk +4 lines, -6 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkBlitter.cpp View 1 3 chunks +5 lines, -12 lines 0 comments Download
M src/core/SkColorFilterShader.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkComposeShader.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkComposeShader.cpp View 1 2 5 chunks +18 lines, -17 lines 0 comments Download
M src/core/SkDraw.cpp View 1 2 3 4 5 chunks +10 lines, -9 lines 0 comments Download
M src/core/SkLocalMatrixShader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPaint.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureShader.h View 1 2 3 3 chunks +14 lines, -12 lines 0 comments Download
M src/core/SkPictureShader.cpp View 1 2 3 4 5 11 chunks +26 lines, -24 lines 0 comments Download
M src/core/SkReadBuffer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkShader.cpp View 1 2 3 4 5 3 chunks +24 lines, -9 lines 0 comments Download
M src/effects/SkTileImageFilter.cpp View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 5 chunks +10 lines, -20 lines 0 comments Download
M src/utils/SkMeshUtils.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/utils/SkNinePatch.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M tools/sk_tool_utils.h View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/sk_tool_utils.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 25 (10 generated)
reed1
4 years, 9 months ago (2016-03-08 14:35:54 UTC) #3
mtklein
https://codereview.chromium.org/1772463002/diff/20001/include/core/SkShader.h File include/core/SkShader.h (right): https://codereview.chromium.org/1772463002/diff/20001/include/core/SkShader.h#newcode351 include/core/SkShader.h:351: #ifdef SK_SUPPORT_LEGACY_CREATESHADER_PTR Wanna make it one more step general ...
4 years, 9 months ago (2016-03-08 14:49:11 UTC) #4
mtklein
generally lgtm, though i sort of glazed over in the repetitive parts https://codereview.chromium.org/1772463002/diff/20001/src/animator/SkDrawGradient.cpp File src/animator/SkDrawGradient.cpp ...
4 years, 9 months ago (2016-03-08 14:55:15 UTC) #5
hal.canary
It might be work running through ASAN and MSAN before landing.
4 years, 9 months ago (2016-03-08 15:00:46 UTC) #6
hal.canary
TODO(me): update example calls in site/user/api/skpaint.md
4 years, 9 months ago (2016-03-08 15:02:25 UTC) #7
reed1
On 2016/03/08 14:55:15, mtklein wrote: > generally lgtm, though i sort of glazed over in ...
4 years, 9 months ago (2016-03-08 15:15:11 UTC) #8
reed1
https://codereview.chromium.org/1772463002/diff/20001/include/core/SkShader.h File include/core/SkShader.h (right): https://codereview.chromium.org/1772463002/diff/20001/include/core/SkShader.h#newcode351 include/core/SkShader.h:351: #ifdef SK_SUPPORT_LEGACY_CREATESHADER_PTR On 2016/03/08 14:49:11, mtklein wrote: > Wanna ...
4 years, 9 months ago (2016-03-08 15:15:19 UTC) #9
f(malita)
https://codereview.chromium.org/1772463002/diff/20001/experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.h File experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.h (right): https://codereview.chromium.org/1772463002/diff/20001/experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.h#newcode65 experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.h:65: int numOctaves, SkScalar seed, Nit: indentation mismatch (here and ...
4 years, 9 months ago (2016-03-08 15:50:35 UTC) #10
reed1
https://codereview.chromium.org/1772463002/diff/20001/experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.h File experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.h (right): https://codereview.chromium.org/1772463002/diff/20001/experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.h#newcode65 experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.h:65: int numOctaves, SkScalar seed, On 2016/03/08 15:50:35, f(malita) wrote: ...
4 years, 9 months ago (2016-03-08 20:17:15 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772463002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772463002/60001
4 years, 9 months ago (2016-03-09 01:10:39 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/6896)
4 years, 9 months ago (2016-03-09 01:13:09 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772463002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772463002/100001
4 years, 9 months ago (2016-03-09 02:13:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772463002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772463002/100001
4 years, 9 months ago (2016-03-09 02:29:16 UTC) #21
f(malita)
lgtm
4 years, 9 months ago (2016-03-09 02:36:15 UTC) #22
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 02:50:06 UTC) #25
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/8a21c9fe7f5fef9e87115defef27bd7218419f28

Powered by Google App Engine
This is Rietveld 408576698