use Make instead of Create to return a shared shader

src/animator/SkDrawGradient.cpp

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "SkDrawGradient.h"
@@ skipping 108 matching lines @@
 }
 
 #ifdef SK_DUMP_ENABLED
 void SkDrawLinearGradient::dump(SkAnimateMaker* maker) {
     dumpBase(maker);
     dumpRest(maker);
     }
 #endif
 
 SkShader* SkDrawLinearGradient::getShader() {
-    if (addPrelude() == 0 || points.count() != 4)
+    if (addPrelude() == 0 || points.count() != 4) {
         return nullptr;
-    SkShader* shader = SkGradientShader::CreateLinear((SkPoint*)points.begin(),
+    }
+    return SkGradientShader::MakeLinear((SkPoint*)points.begin(),
         fColors.begin(), offsets.begin(), fColors.count(), (SkShader::TileMode) tileMode,
-        0, getMatrix());
-    SkAutoTDelete<SkShader> autoDel(shader);

[mtklein, 2016/03/08 14:55:15]

Was this just pointless?

[reed1, 2016/03/08 15:15:19]

I think so

-    (void)autoDel.detach();
-    return shader;
+        0, getMatrix()).release();
 }
 
 
 #if SK_USE_CONDENSED_INFO == 0
 
 const SkMemberInfo SkDrawRadialGradient::fInfo[] = {
     SK_MEMBER_INHERITED,
     SK_MEMBER(center, Point),
     SK_MEMBER(radius, Float)
 };
 
 #endif
 
 DEFINE_GET_MEMBER(SkDrawRadialGradient);
 
 SkDrawRadialGradient::SkDrawRadialGradient() : radius(0) {
     center.set(0, 0);
 }
 
 #ifdef SK_DUMP_ENABLED
 void SkDrawRadialGradient::dump(SkAnimateMaker* maker) {
     dumpBase(maker);
     dumpRest(maker);
 }
 #endif
 
 SkShader* SkDrawRadialGradient::getShader() {
-    if (addPrelude() == 0)
+    if (addPrelude() == 0) {
         return nullptr;
-    SkShader* shader = SkGradientShader::CreateRadial(center,
+    }
+    return SkGradientShader::MakeRadial(center,
         radius, fColors.begin(), offsets.begin(), fColors.count(), (SkShader::TileMode) tileMode,
-        0, getMatrix());
-    SkAutoTDelete<SkShader> autoDel(shader);
-    (void)autoDel.detach();
-    return shader;
+        0, getMatrix()).release();
 }